Source/bindings/scripts/v8_methods.py - Issue 810563007: IDL: Add missing type-check for callback function arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 810563007: IDL: Add missing type-check for callback function arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index bfb3770bbf5ad5903404a59fcb8632f1739d3958..dc506e957cfa56700b1fabcd9eb985b86902af0d 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -224,6 +224,7 @@ def argument_context(interface, method, argument, index):

'idl_type': idl_type.base_type,

'idl_type_object': idl_type,

'index': index,

+ 'is_callback_function': idl_type.is_callback_function,

'is_callback_interface': idl_type.is_callback_interface,

# FIXME: Remove generic 'Dictionary' special-casing

'is_dictionary': idl_type.is_dictionary or idl_type.base_type == 'Dictionary',

« no previous file with comments | « no previous file | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »