Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 810493004: Revert of Revert of Revert of Add d8 target to the GN build. (Closed)

Created:
5 years, 11 months ago by dcarney
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of Revert of Add d8 target to the GN build. (patchset #1 id:1 of https://codereview.chromium.org/833563004/) Reason for revert: This is now really blocking the roll. I believe it's just missing configs -= [ "//build/config/compiler:chromium_code" ] configs += [ "//build/config/compiler:no_chromium_code" ] in the d8 config but I have no way to check. Original issue's description: > Revert of Revert of Add d8 target to the GN build. (patchset #1 id:1 of https://codereview.chromium.org/838983002/) > > Reason for revert: > Relanding because this is not actually blocking the roll. > > Original issue's description: > > Revert of Add d8 target to the GN build. (patchset #2 id:40001 of https://codereview.chromium.org/834113005/) > > > > Reason for revert: > > V8 roll fails due to this change. (see https://codereview.chromium.org/843673003/) > > > > Original issue's description: > > > Add d8 target to the GN build. > > > > > > Also formats the rest of the file with "gn format". This accounts for all the changes except for the "d8" target additions. > > > > > > Committed: https://crrev.com/36383f08c1f692ea797d54a27d7c6b3d3d53b440 > > > Cr-Commit-Position: refs/heads/master@{#25984} > > > > TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org > > NOTREECHECKS=true > > NOTRY=true > > > > Committed: https://crrev.com/ef50fdfdb05e1a3a3822962f5235b804218a5f4e > > Cr-Commit-Position: refs/heads/master@{#25985} > > TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/ebf3c34fb91b4b61f5c32383a115214c516ab5b0 > Cr-Commit-Position: refs/heads/master@{#25996} TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org,yangguo@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/316f860a6bd5fcb55ce0cd4a950e829d2b16acea Cr-Commit-Position: refs/heads/master@{#26050}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -54 lines) Patch
M BUILD.gn View 1 2 chunks +0 lines, -54 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dcarney
Created Revert of Revert of Revert of Add d8 target to the GN build.
5 years, 11 months ago (2015-01-14 11:50:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810493004/40001
5 years, 11 months ago (2015-01-14 11:52:21 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 11 months ago (2015-01-14 11:52:29 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 11:52:45 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/316f860a6bd5fcb55ce0cd4a950e829d2b16acea
Cr-Commit-Position: refs/heads/master@{#26050}

Powered by Google App Engine
This is Rietveld 408576698