Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: BUILD.gn

Issue 810493004: Revert of Revert of Revert of Add d8 target to the GN build. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 5265129659e43a61656b695d8f365d902b842d84..a524ba10a3e7a1cfa792952756940263118c8031 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -191,23 +191,6 @@ action("js2c") {
}
}
-action("d8_js2c") {
- visibility = [ ":*" ] # Only targets in this file can depend on this.
-
- script = "tools/js2c.py"
-
- inputs = [
- "src/d8.js",
- "src/macros.py",
- ]
- outputs = [
- "$target_gen_dir/d8-js.cc",
- ]
-
- args = rebase_path(outputs, root_build_dir) + [ "D8" ] +
- rebase_path(inputs, root_build_dir)
-}
-
action("js2c_experimental") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
@@ -1421,43 +1404,6 @@ if (current_toolchain == host_toolchain) {
"//build/config/sanitizers:deps",
]
}
-
- executable("d8") {
- sources = [
- "src/d8.cc",
- ]
- deps = [
- ":d8_js2c",
- ":v8",
- ":v8_libplatform",
- ]
-
- configs += [
- ":internal_config",
- ":features",
- ":toolchain",
- ]
-
- # TODO(GYP): Build option for readline support.
-
- if (is_posix) {
- sources += [ "src/d8-posix.cc" ]
- } else if (is_win) {
- sources += [ "src/d8-windows.cc" ]
- }
-
- if (component_mode != "shared_library") {
- sources += [
- "src/d8-debug.cc",
- "$target_gen_dir/d8-js.cc",
- ]
- }
- if (v8_enable_i18n_support) {
- deps += [ "//third_party/icu" ]
- }
-
- # TODO(GYP) v8_enable_vtunejit support in d8.
- }
}
###############################################################################
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698