Regexp caching

src/compilation-cache.h

Index: src/compilation-cache.h
diff --git a/src/compilation-cache.h b/src/compilation-cache.h
index a87c4958c6fdaa735d67b60d5c45fb44c3995a49..5a63d930ecad8fc4b85eb285f5c270fcdef98750 100644
--- a/src/compilation-cache.h
+++ b/src/compilation-cache.h
@@ -42,7 +42,9 @@ class CompilationCache {
   enum Entry {
     SCRIPT,
     EVAL_GLOBAL,
-    EVAL_CONTEXTUAL
+    EVAL_CONTEXTUAL,
+    REGEXP,
+    _LAST_ENTRY

[Kasper Lund, 2008/10/24 06:42:50]

I would change _LAST_ENTRY to LAST_ENTRY and let it be equal to REGEXP: enum
Entry { ..., LAST_ENTRY = REGEXP }. The LAST_ENTRY should be the last - not an
additional one. Then you also avoid dealing with it in a switch...

   };
 
   // Finds the script function boilerplate for a source
@@ -59,6 +61,13 @@ class CompilationCache {
   static Handle<JSFunction> LookupEval(Handle<String> source,
                                        Entry entry);
 
+  static Handle<Object> LookupRegExp(Handle<String> source,

[Kasper Lund, 2008/10/24 06:42:50]

Maybe you should explain return value in case of a cache miss?

+                                     int flags);
+
+  static void PutRegExp(Handle<String> source,

[Kasper Lund, 2008/10/24 06:42:50]

Maybe you should rename the Associate method to PutFunction to make it
consistent with PutRegExp? Maybe you should have a comment here that explains
what happens with existing mappings?

+                        int flags,
+                        Handle<FixedArray> data);
+
   // Associate the (source, kind) pair to the boilerplate. This may
   // overwrite an existing mapping.
   static void Associate(Handle<String> source,