Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: runtime/bin/process.cc

Issue 81013002: Cleanup the getting and setting of the socket file descriptor (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Correctly rebased Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/eventhandler.cc ('k') | runtime/bin/socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process.cc
diff --git a/runtime/bin/process.cc b/runtime/bin/process.cc
index 89c8028075e15c53c4c6e10fd1d13d5e2361066f..d7dd894636294bb87338b7590a32a6e67e2b623c 100644
--- a/runtime/bin/process.cc
+++ b/runtime/bin/process.cc
@@ -158,18 +158,14 @@ void FUNCTION_NAME(Process_Start)(Dart_NativeArguments args) {
void FUNCTION_NAME(Process_Wait)(Dart_NativeArguments args) {
Dart_Handle process = Dart_GetNativeArgument(args, 0);
- Dart_Handle stdin_handle = Dart_GetNativeArgument(args, 1);
- Dart_Handle stdout_handle = Dart_GetNativeArgument(args, 2);
- Dart_Handle stderr_handle = Dart_GetNativeArgument(args, 3);
- Dart_Handle exit_handle = Dart_GetNativeArgument(args, 4);
- intptr_t process_stdin;
- intptr_t process_stdout;
- intptr_t process_stderr;
- intptr_t exit_event;
- Socket::GetSocketIdNativeField(stdin_handle, &process_stdin);
- Socket::GetSocketIdNativeField(stdout_handle, &process_stdout);
- Socket::GetSocketIdNativeField(stderr_handle, &process_stderr);
- Socket::GetSocketIdNativeField(exit_handle, &exit_event);
+ intptr_t process_stdin =
+ Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 1));
+ intptr_t process_stdout =
+ Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 2));
+ intptr_t process_stderr =
+ Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 3));
+ intptr_t exit_event =
+ Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 4));
ProcessResult result;
intptr_t pid;
Process::GetProcessIdNativeField(process, &pid);
« no previous file with comments | « runtime/bin/eventhandler.cc ('k') | runtime/bin/socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698