Cleanup the getting and setting of the socket file descriptor

runtime/bin/process.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dartutils.h"
 #include "bin/io_buffer.h"
 #include "bin/platform.h"
 #include "bin/process.h"
 #include "bin/socket.h"
 
@@ skipping 140 matching lines @@
   }
   delete[] string_args;
   delete[] string_environment;
   free(os_error_message);
   Dart_SetReturnValue(args, Dart_NewBoolean(error_code == 0));
 }
 
 
 void FUNCTION_NAME(Process_Wait)(Dart_NativeArguments args) {
   Dart_Handle process =  Dart_GetNativeArgument(args, 0);
-  Dart_Handle stdin_handle =  Dart_GetNativeArgument(args, 1);
-  Dart_Handle stdout_handle =  Dart_GetNativeArgument(args, 2);
-  Dart_Handle stderr_handle =  Dart_GetNativeArgument(args, 3);
-  Dart_Handle exit_handle =  Dart_GetNativeArgument(args, 4);
-  intptr_t process_stdin;
-  intptr_t process_stdout;
-  intptr_t process_stderr;
-  intptr_t exit_event;
-  Socket::GetSocketIdNativeField(stdin_handle, &process_stdin);
-  Socket::GetSocketIdNativeField(stdout_handle, &process_stdout);
-  Socket::GetSocketIdNativeField(stderr_handle, &process_stderr);
-  Socket::GetSocketIdNativeField(exit_handle, &exit_event);
+  intptr_t process_stdin =
+      Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 1));
+  intptr_t process_stdout =
+      Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 2));
+  intptr_t process_stderr =
+      Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 3));
+  intptr_t exit_event =
+      Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 4));
   ProcessResult result;
   intptr_t pid;
   Process::GetProcessIdNativeField(process, &pid);
   if (Process::Wait(pid,
                     process_stdin,
                     process_stdout,
                     process_stderr,
                     exit_event,
                     &result)) {
     Dart_Handle out = result.stdout_data();
@@ skipping 102 matching lines @@
   int external_length = strlen(system_string);
   uint8_t* buffer = NULL;
   Dart_Handle external_array = IOBuffer::Allocate(external_length, &buffer);
   memmove(buffer, system_string, external_length);
   if (utf8 != system_string) free(const_cast<char*>(system_string));
   Dart_SetReturnValue(args, external_array);
 }
 
 }  // namespace bin
 }  // namespace dart