Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 810023002: [turbofan] remove control field from instruction (Closed)

Created:
6 years ago by dcarney
Modified:
6 years ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] remove control field from instruction R=titzer@chromium.org BUG= Committed: https://crrev.com/7b9cb2eb3764d0c807c669e397fc3b84fbefb175 Cr-Commit-Position: refs/heads/master@{#25866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -71 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 5 chunks +8 lines, -12 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 5 chunks +6 lines, -10 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M src/compiler/instruction.h View 5 chunks +3 lines, -12 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcarney
ptal
6 years ago (2014-12-17 13:46:04 UTC) #2
titzer
lgtm
6 years ago (2014-12-17 13:46:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810023002/1
6 years ago (2014-12-17 13:47:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-17 14:10:44 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7b9cb2eb3764d0c807c669e397fc3b84fbefb175 Cr-Commit-Position: refs/heads/master@{#25866}
6 years ago (2014-12-17 14:10:54 UTC) #7
Michael Achenbach
6 years ago (2014-12-18 14:41:06 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/814043002/ by machenbach@chromium.org.

The reason for reverting is: Needed to revert
https://chromium.googlesource.com/v8/v8/+/70b5eb47b39acbf31746f4a116a9b3ce273...
.

Powered by Google App Engine
This is Rietveld 408576698