Get rid of FX_LPCSTR cast.

fpdfsdk/src/javascript/util.cpp

Index: fpdfsdk/src/javascript/util.cpp
diff --git a/fpdfsdk/src/javascript/util.cpp b/fpdfsdk/src/javascript/util.cpp
index d2813f5083e6f13ceec63ebd987361a236e9a5d9..bdef046e8fafb6ad758650a9d2d21c23d103ba95 100644
--- a/fpdfsdk/src/javascript/util.cpp
+++ b/fpdfsdk/src/javascript/util.cpp
@@ -471,8 +471,8 @@ FX_BOOL util::printx(OBJ_METHOD_PARAMS)
 		return FALSE;
 	CFX_WideString sFormat = params[0].operator CFX_WideString();
 	CFX_WideString sSource = params[1].operator CFX_WideString();
-	std::string cFormat = (FX_LPCSTR)CFX_ByteString::FromUnicode(sFormat);
-	std::string cSource = (FX_LPCSTR)CFX_ByteString::FromUnicode(sSource);
+    std::string cFormat = CFX_ByteString::FromUnicode(sFormat).c_str();
+    std::string cSource = CFX_ByteString::FromUnicode(sSource).c_str();

[brucedawson, 2014/12/30 23:13:02]

Can we get a version of FromUnicode that returns std::string? Going from
CFX_WideString to CFX_ByteString to std::string seems like an excess of
conversions. Adding a FromUnicodeTostdstring function would at least centralize
the overhead.

Also, ditto on the indenting.

[Bo Xu, 2014/12/31 00:25:24]

I agree there are too many conversion here.
CFX_ByteString and CFX_WideString are some fundamental data structures. They
were used before in Foxit code to avoid stl(which is not good and in many places
we want to replace with stl). But I feel return a std:string from these data
types are kinda breaking the existing structure.
Looking at the extensive used std:string here is astonishing as they are rarely
mixed with those self-defined data types. Maybe we just leave this one as it is
for now. We could have a though cleanup someday.

 	std::string cDest;
 	printx(cFormat,cSource,cDest);
 	vRet = cDest.c_str();