Get rid of FX_LPCSTR cast.

fpdfsdk/src/javascript/util.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
@@ skipping 453 matching lines @@
                 cPurpose = cFormat;
 }
 
 FX_BOOL util::printx(OBJ_METHOD_PARAMS)
 {
         int iSize = params.size();
         if (iSize<2)
                 return FALSE;
         CFX_WideString sFormat = params[0].operator CFX_WideString();
         CFX_WideString sSource = params[1].operator CFX_WideString();
-        std::string cFormat = (FX_LPCSTR)CFX_ByteString::FromUnicode(sFormat);
-        std::string cSource = (FX_LPCSTR)CFX_ByteString::FromUnicode(sSource);
+    std::string cFormat = CFX_ByteString::FromUnicode(sFormat).c_str();
+    std::string cSource = CFX_ByteString::FromUnicode(sSource).c_str();

[brucedawson, 2014/12/30 23:13:02]

Can we get a version of FromUnicode that returns std::string? Going from
CFX_WideString to CFX_ByteString to std::string seems like an excess of
conversions. Adding a FromUnicodeTostdstring function would at least centralize
the overhead.

Also, ditto on the indenting.

[Bo Xu, 2014/12/31 00:25:24]

I agree there are too many conversion here.
CFX_ByteString and CFX_WideString are some fundamental data structures. They
were used before in Foxit code to avoid stl(which is not good and in many places
we want to replace with stl). But I feel return a std:string from these data
types are kinda breaking the existing structure.
Looking at the extensive used std:string here is astonishing as they are rarely
mixed with those self-defined data types. Maybe we just leave this one as it is
for now. We could have a though cleanup someday.

         std::string cDest;
         printx(cFormat,cSource,cDest);
         vRet = cDest.c_str();
         return TRUE;
 }
 
 void util::printx(const std::string &cFormat,const std::string &cSource2,std::string &cPurpose)
 {
         std::string cSource(cSource2);
         if (!cPurpose.empty())
@@ skipping 154 matching lines @@
         int iSize = params.size();
         if (iSize == 0)
                 return FALSE;
         int nByte = (int)params[0];
         unsigned char cByte = (unsigned char)nByte;
         CFX_WideString csValue;
         csValue.Format(L"%c", cByte);
         vRet = csValue; 
         return TRUE;
 }