core/src/fxcrt/fxcrt_platforms.cpp - Issue 809993004: Get rid of FX_LPCSTR cast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fxcrt_platforms.cpp

Issue 809993004: Get rid of FX_LPCSTR cast. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcrt/fxcrt_platforms.cpp

diff --git a/core/src/fxcrt/fxcrt_platforms.cpp b/core/src/fxcrt/fxcrt_platforms.cpp

index 1c47ee6c9b71f247335668c1c10d0f01a72735be..cdf3d421f5099570cb7d6637a681a49bdb1ee939 100644

--- a/core/src/fxcrt/fxcrt_platforms.cpp

+++ b/core/src/fxcrt/fxcrt_platforms.cpp

@@ -46,7 +46,7 @@ FX_BOOL CFXCRT_FileAccess_CRT::Open(FX_BSTR fileName, FX_DWORD dwMode)

}

CFX_ByteString strMode;

FXCRT_GetFileModeString(dwMode, strMode);

- m_hFile = FXSYS_fopen(fileName.GetCStr(), (FX_LPCSTR)strMode);

+ m_hFile = FXSYS_fopen(fileName.GetCStr(), strMode.c_str());

return m_hFile != NULL;

}

FX_BOOL CFXCRT_FileAccess_CRT::Open(FX_WSTR fileName, FX_DWORD dwMode)