core/src/fxcrt/fx_basic_buffer.cpp - Issue 809993004: Get rid of FX_LPCSTR cast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_basic_buffer.cpp

Issue 809993004: Get rid of FX_LPCSTR cast. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcrt/fx_basic_buffer.cpp

diff --git a/core/src/fxcrt/fx_basic_buffer.cpp b/core/src/fxcrt/fx_basic_buffer.cpp

index b208142d927a107da0fa977b470c5d1356f9fdef..bb8466debeb3e64a8575ecbecc2979710dbe9563 100644

--- a/core/src/fxcrt/fx_basic_buffer.cpp

+++ b/core/src/fxcrt/fx_basic_buffer.cpp

@@ -371,7 +371,7 @@ CFX_ArchiveLoader& CFX_ArchiveLoader::operator >> (CFX_WideString& str)

{

CFX_ByteString encoded;

operator >> (encoded);

- str = CFX_WideString::FromUTF16LE((const unsigned short*)(FX_LPCSTR)encoded, encoded.GetLength());

+ str = CFX_WideString::FromUTF16LE((const unsigned short*)encoded.c_str(), encoded.GetLength());

Tom Sepez 2014/12/30 22:53:26 nit: This cast is confusing, but let's leave it fo

return *this;

}

FX_BOOL CFX_ArchiveLoader::Read(void* pBuf, FX_DWORD dwSize)