Disable new bookmark apps flow.

Disable new bookmark apps flow.

BUG=443392
Committed: https://crrev.com/c9feaef91255c624d293abb68630f90b6d89674d
Cr-Commit-Position: refs/heads/master@{#311359}

[benwells, 2015-01-13 00:33:13]

benwells@chromium.org changed reviewers:
+ thestig@chromium.org

[benwells, 2015-01-13 00:33:51]

benwells@chromium.org changed reviewers:
+ asvitkine@chromium.org

[benwells, 2015-01-13 00:33:51]

+thestig for all
+asvitkine for histograms

[Lei Zhang, 2015-01-13 01:34:40]

https://codereview.chromium.org/809713006/diff/60001/chrome/browser/ui/browse...
File chrome/browser/ui/browser_browsertest.cc (right):

https://codereview.chromium.org/809713006/diff/60001/chrome/browser/ui/browse...
chrome/browser/ui/browser_browsertest.cc:1321: bool new_bookmark_apps_enabled =
Do you need all the conditionals below that depends on this value? Isn't this
always going to be true or false for this test?

[benwells, 2015-01-13 03:22:52]

https://codereview.chromium.org/809713006/diff/60001/chrome/browser/ui/browse...
File chrome/browser/ui/browser_browsertest.cc (right):

https://codereview.chromium.org/809713006/diff/60001/chrome/browser/ui/browse...
chrome/browser/ui/browser_browsertest.cc:1321: bool new_bookmark_apps_enabled =
On 2015/01/13 01:34:40, Lei Zhang wrote:
> Do you need all the conditionals below that depends on this value? Isn't this
> always going to be true or false for this test?

I thought it might be better if the test would pass with the flag on or off, but
I can just adjust the expected values. Would you prefer it like that?

[Lei Zhang, 2015-01-13 03:26:27]

On 2015/01/13 03:22:52, benwells wrote:
>
https://codereview.chromium.org/809713006/diff/60001/chrome/browser/ui/browse...
> File chrome/browser/ui/browser_browsertest.cc (right):
> 
>
https://codereview.chromium.org/809713006/diff/60001/chrome/browser/ui/browse...
> chrome/browser/ui/browser_browsertest.cc:1321: bool new_bookmark_apps_enabled
=
> On 2015/01/13 01:34:40, Lei Zhang wrote:
> > Do you need all the conditionals below that depends on this value? Isn't
this
> > always going to be true or false for this test?
> 
> I thought it might be better if the test would pass with the flag on or off,
but
> I can just adjust the expected values. Would you prefer it like that?

How many times do you expect to flip the switch? I guess we can leave it like
this until we stop flipping. Eventually IsStreamlinedHostedAppsEnabled() will go
away and we'll need to adjust the tests to "the way they should be."

lgtm

[benwells, 2015-01-13 03:30:13]

On 2015/01/13 03:26:27, Lei Zhang wrote:
> On 2015/01/13 03:22:52, benwells wrote:
> >
>
https://codereview.chromium.org/809713006/diff/60001/chrome/browser/ui/browse...
> > File chrome/browser/ui/browser_browsertest.cc (right):
> > 
> >
>
https://codereview.chromium.org/809713006/diff/60001/chrome/browser/ui/browse...
> > chrome/browser/ui/browser_browsertest.cc:1321: bool
new_bookmark_apps_enabled
> =
> > On 2015/01/13 01:34:40, Lei Zhang wrote:
> > > Do you need all the conditionals below that depends on this value? Isn't
> this
> > > always going to be true or false for this test?
> > 
> > I thought it might be better if the test would pass with the flag on or off,
> but
> > I can just adjust the expected values. Would you prefer it like that?
> 
> How many times do you expect to flip the switch? I guess we can leave it like
> this until we stop flipping. Eventually IsStreamlinedHostedAppsEnabled() will
go
> away and we'll need to adjust the tests to "the way they should be."
> 
> lgtm

Cool. Hopefully it will flip one more time, then as you say
IsStreamlinedHostedAppsEnabled will be removed and the tests can be made simple
again.

Thanks!

[Alexei Svitkine (slow), 2015-01-13 14:53:07]

lgtm

[benwells, 2015-01-13 21:39:30]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2015-01-13 21:39:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/809713006/60001

[commit-bot: I haz the power, 2015-01-13 23:25:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-13 23:26:10]

Patchset 4 (id:??) landed as
https://crrev.com/c9feaef91255c624d293abb68630f90b6d89674d
Cr-Commit-Position: refs/heads/master@{#311359}