Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4265)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 809713006: Disable new bookmark apps flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix woopsies Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
index ec6d1a32aa19923c9d5160b895db1939f2ed4e43..2aea5d51ef26e70081bde8590d6c20f225ec446d 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
@@ -13,6 +13,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/first_run/first_run.h"
#include "chrome/browser/infobars/infobar_service.h"
@@ -325,9 +326,12 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, OpenAppShortcutNoPref) {
Browser* new_browser = FindOneOtherBrowser(browser());
ASSERT_TRUE(new_browser);
- // It should be a standard tabbed window, not an app window.
- EXPECT_FALSE(new_browser->is_app());
- EXPECT_TRUE(new_browser->is_type_tabbed());
+ // If new bookmark apps are enabled, it should be a standard tabbed window,
+ // not an app window; otherwise the reverse should be true.
+ bool new_bookmark_apps_enabled =
+ extensions::util::IsStreamlinedHostedAppsEnabled();
+ EXPECT_EQ(!new_bookmark_apps_enabled, new_browser->is_app());
+ EXPECT_EQ(new_bookmark_apps_enabled, new_browser->is_type_tabbed());
}
IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, OpenAppShortcutWindowPref) {

Powered by Google App Engine
This is Rietveld 408576698