tools/perf/measurements/task_execution_time.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/task_execution_time.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix linter issues Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/task_execution_time.py

diff --git a/tools/perf/measurements/task_execution_time.py b/tools/perf/measurements/task_execution_time.py

index f33a85f1474a42f03f4107bd284f09f13dc86b00..d36fcc0a4c35b15ad831344f81a569b6f9e66a0c 100644

--- a/tools/perf/measurements/task_execution_time.py

+++ b/tools/perf/measurements/task_execution_time.py

@@ -7,6 +7,7 @@ from telemetry.core.platform import tracing_options

from telemetry.timeline.model import TimelineModel

from telemetry.page import page_test

from telemetry.util import statistics

+from telemetry.value import improvement_direction

from telemetry.value import scalar

_CATEGORIES = ['webkit.console',

@@ -56,7 +57,8 @@ class TaskExecutionTime(page_test.PageTest):

task.key,

'ms',

task.median_self_duration,

- description = 'Slowest tasks'))

+ description = 'Slowest tasks',

+ improvement_direction=improvement_direction.DOWN))

@staticmethod

def GetTasks(process):

« no previous file with comments | « tools/perf/measurements/tab_switching.py ('k') | tools/perf/metrics/cpu.py » ('j') | tools/telemetry/telemetry/value/scalar.py » ('J')