Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: tools/perf/measurements/polymer_load.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/polymer_load.py
diff --git a/tools/perf/measurements/polymer_load.py b/tools/perf/measurements/polymer_load.py
index 9120e31359c23d94bb20e1f1a626729469bae282..397945b2653fb591c8f97b480bf74453da1a3fba 100644
--- a/tools/perf/measurements/polymer_load.py
+++ b/tools/perf/measurements/polymer_load.py
@@ -4,6 +4,7 @@
from telemetry.page import page
from telemetry.page import page_test
+from telemetry.value import improvement_direction
from telemetry.value import scalar
@@ -36,4 +37,5 @@ class PolymerLoadMeasurement(page_test.PageTest):
def ValidateAndMeasurePage(self, _, tab, results):
result = int(tab.EvaluateJavaScript('__polymer_ready_time'))
results.AddValue(scalar.ScalarValue(
- results.current_page, 'Total', 'ms', result))
+ results.current_page, 'Total', 'ms', result,
+ improvement_direction=improvement_direction.DOWN))

Powered by Google App Engine
This is Rietveld 408576698