Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: tools/perf/measurements/polymer_load.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.page import page 5 from telemetry.page import page
6 from telemetry.page import page_test 6 from telemetry.page import page_test
7 from telemetry.value import improvement_direction
7 from telemetry.value import scalar 8 from telemetry.value import scalar
8 9
9 10
10 class PageForPolymerLoad(page.Page): 11 class PageForPolymerLoad(page.Page):
11 12
12 def __init__(self, url, page_set, ready_event='polymer-ready'): 13 def __init__(self, url, page_set, ready_event='polymer-ready'):
13 super(PageForPolymerLoad, self).__init__( 14 super(PageForPolymerLoad, self).__init__(
14 url=url, 15 url=url,
15 page_set=page_set) 16 page_set=page_set)
16 self.script_to_evaluate_on_commit = ''' 17 self.script_to_evaluate_on_commit = '''
(...skipping 12 matching lines...) Expand all
29 30
30 31
31 class PolymerLoadMeasurement(page_test.PageTest): 32 class PolymerLoadMeasurement(page_test.PageTest):
32 def __init__(self): 33 def __init__(self):
33 super(PolymerLoadMeasurement, self).__init__( 34 super(PolymerLoadMeasurement, self).__init__(
34 action_name_to_run='RunPageInteractions') 35 action_name_to_run='RunPageInteractions')
35 36
36 def ValidateAndMeasurePage(self, _, tab, results): 37 def ValidateAndMeasurePage(self, _, tab, results):
37 result = int(tab.EvaluateJavaScript('__polymer_ready_time')) 38 result = int(tab.EvaluateJavaScript('__polymer_ready_time'))
38 results.AddValue(scalar.ScalarValue( 39 results.AddValue(scalar.ScalarValue(
39 results.current_page, 'Total', 'ms', result)) 40 results.current_page, 'Total', 'ms', result,
41 improvement_direction=improvement_direction.DOWN))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698