tools/perf/measurements/rasterize_and_record_micro.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/rasterize_and_record_micro.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/perf/benchmarks/dom_perf.py ('K') | « tools/perf/measurements/polymer_load.py ('k') | tools/perf/measurements/record_per_area.py » ('j') | tools/telemetry/telemetry/value/__init__.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/measurements/rasterize_and_record_micro.py

diff --git a/tools/perf/measurements/rasterize_and_record_micro.py b/tools/perf/measurements/rasterize_and_record_micro.py

index 3523a7bb362b91c7422ad4275f2a2498be640745..363cd540adc196a1d8e06bb10840a8c7f4e219a0 100644

--- a/tools/perf/measurements/rasterize_and_record_micro.py

+++ b/tools/perf/measurements/rasterize_and_record_micro.py

@@ -77,20 +77,22 @@ class RasterizeAndRecordMicro(page_test.PageTest):

results.AddValue(scalar.ScalarValue(

results.current_page, 'pixels_rasterized', 'pixels', pixels_rasterized))

results.AddValue(scalar.ScalarValue(

- results.current_page, 'rasterize_time', 'ms', rasterize_time))

+ results.current_page, 'rasterize_time', 'ms', rasterize_time,

+ higher_is_better=False))

results.AddValue(scalar.ScalarValue(

results.current_page, 'viewport_picture_size', 'bytes',

- picture_memory_usage))

+ picture_memory_usage, higher_is_better=False))

results.AddValue(scalar.ScalarValue(

- results.current_page, 'record_time', 'ms', record_time))

+ results.current_page, 'record_time', 'ms', record_time,

+ higher_is_better=False))

record_time_sk_null_canvas = data['record_time_sk_null_canvas_ms']

record_time_painting_disabled = data['record_time_painting_disabled_ms']

results.AddValue(scalar.ScalarValue(

results.current_page, 'record_time_sk_null_canvas', 'ms',

- record_time_sk_null_canvas))

+ record_time_sk_null_canvas, higher_is_better=False))

results.AddValue(scalar.ScalarValue(

results.current_page, 'record_time_painting_disabled', 'ms',

- record_time_painting_disabled))

+ record_time_painting_disabled, higher_is_better=False))

if self._report_detailed_results:

pixels_rasterized_with_non_solid_color = \

@@ -112,7 +114,7 @@ class RasterizeAndRecordMicro(page_test.PageTest):

results.AddValue(scalar.ScalarValue(

results.current_page, 'total_size_of_pictures_in_piles', 'bytes',

- total_pictures_in_pile_size))

+ total_pictures_in_pile_size, higher_is_better=False))

results.AddValue(scalar.ScalarValue(

results.current_page, 'pixels_rasterized_with_non_solid_color',

'pixels', pixels_rasterized_with_non_solid_color))