tools/perf/measurements/polymer_load.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/polymer_load.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/perf/benchmarks/dom_perf.py ('K') | « tools/perf/measurements/page_cycler.py ('k') | tools/perf/measurements/rasterize_and_record_micro.py » ('j') | tools/telemetry/telemetry/value/__init__.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/measurements/polymer_load.py

diff --git a/tools/perf/measurements/polymer_load.py b/tools/perf/measurements/polymer_load.py

index a373a4fcccf962f586d55d55774e3fe5a7464fa1..c2a351bee9ceb065fccc2a5159268bfdf3a8e4ed 100644

--- a/tools/perf/measurements/polymer_load.py

+++ b/tools/perf/measurements/polymer_load.py

@@ -32,4 +32,4 @@ class PolymerLoadMeasurement(page_test.PageTest):

def ValidateAndMeasurePage(self, _, tab, results):

result = int(tab.EvaluateJavaScript('__polymer_ready_time'))

results.AddValue(scalar.ScalarValue(

- results.current_page, 'Total', 'ms', result))

+ results.current_page, 'Total', 'ms', result, higher_is_better=False))