Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: chrome/browser/signin/signin_global_error_factory.cc

Issue 809313009: Make the SigninErrorController a PKS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary header Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/signin_global_error_factory.cc
diff --git a/chrome/browser/signin/signin_global_error_factory.cc b/chrome/browser/signin/signin_global_error_factory.cc
index 47ecb908b0d2f025c9c46bd152e4bfd398af624f..a1900a7dbef1c8e34bc8b0ec55a046665e30ed8d 100644
--- a/chrome/browser/signin/signin_global_error_factory.cc
+++ b/chrome/browser/signin/signin_global_error_factory.cc
@@ -6,7 +6,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
+#include "chrome/browser/signin/signin_error_controller_factory.h"
#include "chrome/browser/signin/signin_global_error.h"
#include "chrome/browser/ui/global_error/global_error_service_factory.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h"
@@ -20,7 +20,7 @@ SigninGlobalErrorFactory::SigninGlobalErrorFactory()
: BrowserContextKeyedServiceFactory(
"SigninGlobalError",
BrowserContextDependencyManager::GetInstance()) {
- DependsOn(ProfileOAuth2TokenServiceFactory::GetInstance());
+ DependsOn(SigninErrorControllerFactory::GetInstance());
DependsOn(GlobalErrorServiceFactory::GetInstance());
}
@@ -47,9 +47,6 @@ KeyedService* SigninGlobalErrorFactory::BuildServiceInstanceFor(
Profile* profile = static_cast<Profile*>(context);
- SigninErrorController* controller =
- ProfileOAuth2TokenServiceFactory::GetForProfile(profile)->
- signin_error_controller();
-
- return new SigninGlobalError(controller, profile);
+ return new SigninGlobalError(
+ SigninErrorControllerFactory::GetForProfile(profile), profile);
}
« no previous file with comments | « chrome/browser/signin/signin_error_notifier_factory_ash.cc ('k') | chrome/browser/signin/signin_global_error_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698