Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: chrome/browser/signin/signin_error_notifier_factory_ash.cc

Issue 809313009: Make the SigninErrorController a PKS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary header Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/signin_error_notifier_factory_ash.cc
diff --git a/chrome/browser/signin/signin_error_notifier_factory_ash.cc b/chrome/browser/signin/signin_error_notifier_factory_ash.cc
index 100df639dc533099c634532f93e6fc72117cce6d..75c975f4306e2e3a2997e12ef69c9679226df1ca 100644
--- a/chrome/browser/signin/signin_error_notifier_factory_ash.cc
+++ b/chrome/browser/signin/signin_error_notifier_factory_ash.cc
@@ -7,7 +7,7 @@
#include "ash/shell.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
+#include "chrome/browser/signin/signin_error_controller_factory.h"
#include "chrome/browser/signin/signin_error_notifier_ash.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h"
#include "components/signin/core/browser/profile_oauth2_token_service.h"
@@ -16,7 +16,7 @@ SigninErrorNotifierFactory::SigninErrorNotifierFactory()
: BrowserContextKeyedServiceFactory(
"SigninErrorNotifier",
BrowserContextDependencyManager::GetInstance()) {
- DependsOn(ProfileOAuth2TokenServiceFactory::GetInstance());
+ DependsOn(SigninErrorControllerFactory::GetInstance());
}
SigninErrorNotifierFactory::~SigninErrorNotifierFactory() {}
@@ -40,9 +40,6 @@ KeyedService* SigninErrorNotifierFactory::BuildServiceInstanceFor(
Profile* profile = static_cast<Profile*>(context);
- SigninErrorController* controller =
- ProfileOAuth2TokenServiceFactory::GetForProfile(profile)->
- signin_error_controller();
-
- return new SigninErrorNotifier(controller, profile);
+ return new SigninErrorNotifier(
+ SigninErrorControllerFactory::GetForProfile(profile), profile);
}
« no previous file with comments | « chrome/browser/signin/signin_error_notifier_ash_unittest.cc ('k') | chrome/browser/signin/signin_global_error_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698