Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2022)

Issue 809103003: Revert of Map WebURLRequest::RequestContextPlugin to RESOURCE_TYPE_OBJECT. (Closed)

Created:
4 years, 10 months ago by jianli
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Map WebURLRequest::RequestContextPlugin to RESOURCE_TYPE_OBJECT. (patchset #6 id:600001 of https://codereview.chromium.org/630973002/) Reason for revert: Speculative revert since it might cause browser test PDFExtensionTest.BasicPlugin to fail. http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20(dbg)/builds/4962 http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/11223 http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/7530 Original issue's description: > Map WebURLRequest::RequestContextPlugin to RESOURCE_TYPE_OBJECT. > > The WebRequest API should treat both object requests, and requests made > from those objects (e.g. Flash requesting an .mp4 resource) as type > Object. We used to do this, then I broke it. :( Now I'm fixing it. :) > > BUG=410382 > R=vabr@chromium.org > > Committed: https://crrev.com/c3e50e6354188999da307094c5c037d5933f1bc3 > Cr-Commit-Position: refs/heads/master@{#308787} TBR=jochen@chromium.org,jam@chromium.org,vabr@chromium.org,mkwst@chromium.org NOTREECHECKS=true NOTRY=true BUG=410382 Committed: https://crrev.com/9ae580a9293de35ec2e97b303967c809192c646c Cr-Commit-Position: refs/heads/master@{#308834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/child/web_url_request_util.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jianli
Created Revert of Map WebURLRequest::RequestContextPlugin to RESOURCE_TYPE_OBJECT.
4 years, 10 months ago (2014-12-17 19:15:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809103003/1
4 years, 10 months ago (2014-12-17 19:15:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2014-12-17 19:16:52 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9ae580a9293de35ec2e97b303967c809192c646c Cr-Commit-Position: refs/heads/master@{#308834}
4 years, 10 months ago (2014-12-17 19:17:34 UTC) #4
jianli
The revert fixed the issue.
4 years, 10 months ago (2014-12-17 21:17:44 UTC) #5
Mike West
4 years, 10 months ago (2014-12-17 21:18:27 UTC) #6
Message was sent while issue was closed.
On 2014/12/17 21:17:44, jianli wrote:
> The revert fixed the issue.

LGTM, then. Thanks.

Powered by Google App Engine
This is Rietveld 408576698