Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tools/perf/page_sets/typical_25.py

Issue 808893002: [Telemetry] Remove session_restore's use of PageTest.CanRunForPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Drop session_restore's use of CanRunForPage. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/typical_25.py
diff --git a/tools/perf/page_sets/typical_25.py b/tools/perf/page_sets/typical_25.py
index 89395a39a3bcfaa9e349705d1a95b486784f9b31..8f8736427721ec3c86edaefe7cdd58a864091fa1 100644
--- a/tools/perf/page_sets/typical_25.py
+++ b/tools/perf/page_sets/typical_25.py
@@ -5,12 +5,18 @@ from telemetry.page import page as page_module
from telemetry.page import page_set as page_set_module
+# Share the following constants with SessionRestorePageSet.
+USER_AGENT_TYPE = 'desktop'
+ARCHIVE_DATA_FILE = 'data/typical_25.json'
+PAGE_SET_BUCKET = page_set_module.PARTNER_BUCKET
+
+
class Typical25Page(page_module.Page):
def __init__(self, url, page_set):
super(Typical25Page, self).__init__(url=url, page_set=page_set)
- self.user_agent_type = 'desktop'
- self.archive_data_file = 'data/typical_25.json'
+ self.user_agent_type = USER_AGENT_TYPE
+ self.archive_data_file = ARCHIVE_DATA_FILE
def RunPageInteractions(self, action_runner):
interaction = action_runner.BeginGestureInteraction(
@@ -25,9 +31,9 @@ class Typical25PageSet(page_set_module.PageSet):
def __init__(self):
super(Typical25PageSet, self).__init__(
- user_agent_type='desktop',
- archive_data_file='data/typical_25.json',
- bucket=page_set_module.PARTNER_BUCKET)
+ user_agent_type=USER_AGENT_TYPE,
+ archive_data_file=ARCHIVE_DATA_FILE,
+ bucket=PAGE_SET_BUCKET)
urls_list = [
# Why: Alexa games #48
« tools/perf/benchmarks/session_restore.py ('K') | « tools/perf/page_sets/session_restore.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698