Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1808)

Unified Diff: tools/perf/benchmarks/session_restore.py

Issue 808893002: [Telemetry] Remove session_restore's use of PageTest.CanRunForPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Drop session_restore's use of CanRunForPage. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/session_restore.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/session_restore.py
diff --git a/tools/perf/benchmarks/session_restore.py b/tools/perf/benchmarks/session_restore.py
index 2591c0bc249876f059a4c2a0a84f7b94ec5dd3fb..da470985ab77efa6216ace0ebe6951218e93a6d2 100644
--- a/tools/perf/benchmarks/session_restore.py
+++ b/tools/perf/benchmarks/session_restore.py
@@ -6,13 +6,13 @@ import os
import tempfile
from measurements import session_restore
-import page_sets
+from page_sets import session_restore as session_restore_page_set
from profile_creators import small_profile_creator
from telemetry import benchmark
from telemetry.page import profile_generator
-
class _SessionRestoreTest(benchmark.Benchmark):
+ page_set = session_restore_page_set.SessionRestorePageSet
nednguyen 2015/01/08 01:54:14 I think this will lead to naming change.
@classmethod
def ProcessCommandLineArgs(cls, parser, args):
@@ -42,7 +42,6 @@ class _SessionRestoreTest(benchmark.Benchmark):
@benchmark.Disabled('android', 'linux', 'reference')
class SessionRestoreColdTypical25(_SessionRestoreTest):
tag = 'cold'
- page_set = page_sets.Typical25PageSet
options = {'pageset_repeat': 5}
@@ -50,5 +49,4 @@ class SessionRestoreColdTypical25(_SessionRestoreTest):
@benchmark.Disabled('android', 'linux', 'reference')
class SessionRestoreWarmTypical25(_SessionRestoreTest):
tag = 'warm'
- page_set = page_sets.Typical25PageSet
options = {'pageset_repeat': 20}
« no previous file with comments | « no previous file | tools/perf/page_sets/session_restore.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698