Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/win.py

Issue 808163002: Windows run-webkit-tests broke if --disable-breakpad was used (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Windows run-webkit-tests broke if --disable-breakpad was used Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/layout_tests/port/win.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/win.py b/Tools/Scripts/webkitpy/layout_tests/port/win.py
index f20649701f37f49f2ca69fc81eae00c7ac0d285d..74757441af6361a83980ab78c6b757748bcfc0bc 100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/win.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/win.py
@@ -78,8 +78,8 @@ class WinPort(base.Port):
assert self._version in self.SUPPORTED_VERSIONS, "%s is not in %s" % (self._version, self.SUPPORTED_VERSIONS)
if not self.get_option('disable_breakpad'):
self._dump_reader = DumpReaderWin(host, self._build_path())
- self._crash_service = None
self._crash_service_available = None
+ self._crash_service = None
Dirk Pranke 2014/12/17 22:04:47 ick, it's bad to have member fields that only cond
Daniel Bratell 2014/12/18 16:51:41 Done.
def additional_drt_flag(self):
flags = super(WinPort, self).additional_drt_flag()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698