Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 80813002: Cleanup: Remove many unused wstring string_utils. (Closed)

Created:
7 years, 1 month ago by Lei Zhang
Modified:
7 years, 1 month ago
Reviewers:
Nico, scottmg
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -179 lines) Patch
M base/strings/string_util.h View 12 chunks +0 lines, -50 lines 0 comments Download
M base/strings/string_util.cc View 12 chunks +8 lines, -85 lines 0 comments Download
M base/strings/string_util_unittest.cc View 5 chunks +46 lines, -36 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_win.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
7 years, 1 month ago (2013-11-21 23:14:02 UTC) #1
scottmg
c/b/gamepad lgtm
7 years, 1 month ago (2013-11-21 23:29:18 UTC) #2
Nico
lgtm BUG=string16 bug?
7 years, 1 month ago (2013-11-22 00:09:33 UTC) #3
Lei Zhang
On 2013/11/22 00:09:33, Nico (in Tokyo until Nov 25) wrote: > lgtm > > BUG=string16 ...
7 years, 1 month ago (2013-11-22 00:10:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/80813002/210001
7 years, 1 month ago (2013-11-22 00:13:53 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=37543
7 years, 1 month ago (2013-11-22 00:33:59 UTC) #6
scottmg
On 2013/11/22 00:33:59, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 1 month ago (2013-11-22 00:42:54 UTC) #7
Lei Zhang
7 years, 1 month ago (2013-11-22 02:29:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r236685 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698