Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: chrome/browser/history/history_backend.h

Issue 808123003: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed fwd declaration of KeywordSearchUpdatedDetails Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_backend.h
diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h
index d0987e541af75e6c71a21cf38c88aa38b9cbf99b..f587f4871ec5f599b92111ffa2a9f2bfe6dcb8b2 100644
--- a/chrome/browser/history/history_backend.h
+++ b/chrome/browser/history/history_backend.h
@@ -143,6 +143,14 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// be forwarded to the HistoryServiceObservers in the correct thread.
virtual void NotifyURLsModified(const URLRows& changed_urls) = 0;
+ // Notify HistoryService that some keyword has be searched in omni box. The
nshaik 2014/12/30 18:56:35 nit: has "to" be searched
+ // event will be forwarded to the HistoryServiceObservers in the correct
+ // thread.
+ virtual void NotifyHistoryKeywordSearchTermUpdated(
sdefresne 2014/12/29 09:53:26 nit: rename to NotifyKeyedSearchTermUpdated (we ar
sdefresne 2014/12/29 09:53:26 nit: rename to NotifyKeyedSearchTermUpdated (we ar
Abhishek 2014/12/29 14:12:40 Done.
+ const URLRow& row,
+ KeywordID keyword_id,
+ const base::string16& term) = 0;
+
// Broadcasts the specified notification to the notification service.
// This is implemented here because notifications must only be sent from
// the main thread. This is the only method that doesn't identify the

Powered by Google App Engine
This is Rietveld 408576698