Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Side by Side Diff: chrome/browser/history/history_backend.h

Issue 808123003: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed fwd declaration of KeywordSearchUpdatedDetails Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
6 #define CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 // be forwarded to the HistoryServiceObservers in the correct thread. 136 // be forwarded to the HistoryServiceObservers in the correct thread.
137 virtual void NotifyURLVisited(ui::PageTransition transition, 137 virtual void NotifyURLVisited(ui::PageTransition transition,
138 const URLRow& row, 138 const URLRow& row,
139 const RedirectList& redirects, 139 const RedirectList& redirects,
140 base::Time visit_time) = 0; 140 base::Time visit_time) = 0;
141 141
142 // Notify HistoryService that some URLs have been modified. The event will 142 // Notify HistoryService that some URLs have been modified. The event will
143 // be forwarded to the HistoryServiceObservers in the correct thread. 143 // be forwarded to the HistoryServiceObservers in the correct thread.
144 virtual void NotifyURLsModified(const URLRows& changed_urls) = 0; 144 virtual void NotifyURLsModified(const URLRows& changed_urls) = 0;
145 145
146 // Notify HistoryService that some keyword has be searched in omni box. The
nshaik 2014/12/30 18:56:35 nit: has "to" be searched
147 // event will be forwarded to the HistoryServiceObservers in the correct
148 // thread.
149 virtual void NotifyHistoryKeywordSearchTermUpdated(
sdefresne 2014/12/29 09:53:26 nit: rename to NotifyKeyedSearchTermUpdated (we ar
sdefresne 2014/12/29 09:53:26 nit: rename to NotifyKeyedSearchTermUpdated (we ar
Abhishek 2014/12/29 14:12:40 Done.
150 const URLRow& row,
151 KeywordID keyword_id,
152 const base::string16& term) = 0;
153
146 // Broadcasts the specified notification to the notification service. 154 // Broadcasts the specified notification to the notification service.
147 // This is implemented here because notifications must only be sent from 155 // This is implemented here because notifications must only be sent from
148 // the main thread. This is the only method that doesn't identify the 156 // the main thread. This is the only method that doesn't identify the
149 // caller because notifications must always be sent. 157 // caller because notifications must always be sent.
150 virtual void BroadcastNotifications(int type, 158 virtual void BroadcastNotifications(int type,
151 scoped_ptr<HistoryDetails> details) = 0; 159 scoped_ptr<HistoryDetails> details) = 0;
152 160
153 // Invoked when the backend has finished loading the db. 161 // Invoked when the backend has finished loading the db.
154 virtual void DBLoaded() = 0; 162 virtual void DBLoaded() = 0;
155 }; 163 };
(...skipping 754 matching lines...) Expand 10 before | Expand all | Expand 10 after
910 918
911 // List of observers 919 // List of observers
912 ObserverList<HistoryBackendObserver> observers_; 920 ObserverList<HistoryBackendObserver> observers_;
913 921
914 DISALLOW_COPY_AND_ASSIGN(HistoryBackend); 922 DISALLOW_COPY_AND_ASSIGN(HistoryBackend);
915 }; 923 };
916 924
917 } // namespace history 925 } // namespace history
918 926
919 #endif // CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_ 927 #endif // CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698