Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: chrome/browser/android/provider/chrome_browser_provider.h

Issue 808123003: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch for android port Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/provider/chrome_browser_provider.h
diff --git a/chrome/browser/android/provider/chrome_browser_provider.h b/chrome/browser/android/provider/chrome_browser_provider.h
index 29f4993d519cf3d45a652ec399a855845f1d2494..77df1fb8a55b8f8cf2c2ef644b7105b67d0e2295 100644
--- a/chrome/browser/android/provider/chrome_browser_provider.h
+++ b/chrome/browser/android/provider/chrome_browser_provider.h
@@ -185,6 +185,8 @@ class ChromeBrowserProvider : public bookmarks::BaseBookmarkModelObserver,
// Deals with updates to the history service.
void OnHistoryChanged();
+ void OnSearchTermUpdated();
sdefresne 2014/12/24 09:03:43 style: comment this method
Abhishek 2014/12/24 19:39:40 Done.
+
// Override history::HistoryServiceObserver.
virtual void OnURLVisited(HistoryService* history_service,
sdefresne 2014/12/24 09:03:43 style: method should only have one of "override",
Abhishek 2014/12/24 19:39:41 Done.
ui::PageTransition transition,
@@ -192,6 +194,12 @@ class ChromeBrowserProvider : public bookmarks::BaseBookmarkModelObserver,
const history::RedirectList& redirects,
base::Time visit_time) override;
sdefresne 2014/12/24 09:03:43 nit: remove empty line
Abhishek 2014/12/24 19:39:41 Done.
+ virtual void HistoryKeywordSearchTermUpdated(
+ HistoryService* history_service,
+ const history::URLRow& row,
+ history::KeywordID keyword_id,
+ const base::string16& term) override;
+
// Override content::NotificationObserver.
virtual void Observe(int type,
const content::NotificationSource& source,

Powered by Google App Engine
This is Rietveld 408576698