Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: chrome/browser/android/provider/chrome_browser_provider.h

Issue 808123003: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch for android port Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
6 #define CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 6 #define CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
7 7
8 #include "base/android/jni_weak_ref.h" 8 #include "base/android/jni_weak_ref.h"
9 #include "base/android/scoped_java_ref.h" 9 #include "base/android/scoped_java_ref.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 virtual ~ChromeBrowserProvider(); 178 virtual ~ChromeBrowserProvider();
179 179
180 // Override bookmarks::BaseBookmarkModelObserver. 180 // Override bookmarks::BaseBookmarkModelObserver.
181 virtual void BookmarkModelChanged() override; 181 virtual void BookmarkModelChanged() override;
182 virtual void ExtensiveBookmarkChangesBeginning(BookmarkModel* model) override; 182 virtual void ExtensiveBookmarkChangesBeginning(BookmarkModel* model) override;
183 virtual void ExtensiveBookmarkChangesEnded(BookmarkModel* model) override; 183 virtual void ExtensiveBookmarkChangesEnded(BookmarkModel* model) override;
184 184
185 // Deals with updates to the history service. 185 // Deals with updates to the history service.
186 void OnHistoryChanged(); 186 void OnHistoryChanged();
187 187
188 void OnSearchTermUpdated();
sdefresne 2014/12/24 09:03:43 style: comment this method
Abhishek 2014/12/24 19:39:40 Done.
189
188 // Override history::HistoryServiceObserver. 190 // Override history::HistoryServiceObserver.
189 virtual void OnURLVisited(HistoryService* history_service, 191 virtual void OnURLVisited(HistoryService* history_service,
sdefresne 2014/12/24 09:03:43 style: method should only have one of "override",
Abhishek 2014/12/24 19:39:41 Done.
190 ui::PageTransition transition, 192 ui::PageTransition transition,
191 const history::URLRow& row, 193 const history::URLRow& row,
192 const history::RedirectList& redirects, 194 const history::RedirectList& redirects,
193 base::Time visit_time) override; 195 base::Time visit_time) override;
194 196
sdefresne 2014/12/24 09:03:43 nit: remove empty line
Abhishek 2014/12/24 19:39:41 Done.
197 virtual void HistoryKeywordSearchTermUpdated(
198 HistoryService* history_service,
199 const history::URLRow& row,
200 history::KeywordID keyword_id,
201 const base::string16& term) override;
202
195 // Override content::NotificationObserver. 203 // Override content::NotificationObserver.
196 virtual void Observe(int type, 204 virtual void Observe(int type,
197 const content::NotificationSource& source, 205 const content::NotificationSource& source,
198 const content::NotificationDetails& details) override; 206 const content::NotificationDetails& details) override;
199 207
200 JavaObjectWeakGlobalRef weak_java_provider_; 208 JavaObjectWeakGlobalRef weak_java_provider_;
201 209
202 // Profile must outlive this object. 210 // Profile must outlive this object.
203 // 211 //
204 // BookmarkModel, HistoryService and history::TopSites lifetime is bound to 212 // BookmarkModel, HistoryService and history::TopSites lifetime is bound to
(...skipping 12 matching lines...) Expand all
217 content::NotificationRegistrar notification_registrar_; 225 content::NotificationRegistrar notification_registrar_;
218 ScopedObserver<HistoryService, HistoryServiceObserver> 226 ScopedObserver<HistoryService, HistoryServiceObserver>
219 history_service_observer_; 227 history_service_observer_;
220 228
221 bool handling_extensive_changes_; 229 bool handling_extensive_changes_;
222 230
223 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserProvider); 231 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserProvider);
224 }; 232 };
225 233
226 #endif // CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 234 #endif // CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698