chrome/browser/history/history_service.h - Issue 808123003: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_service.h

Issue 808123003: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: inline code for provider class Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/history_backend.h ('K') | « chrome/browser/history/history_notifications.cc ('k') | chrome/browser/history/history_service.cc » ('j') | components/history/core/browser/history_service_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/history_service.h

diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h

index 5a8a05ece5fb0fd55491672aaa01fdb16ed6b493..2cd4a70dd125ea1a0356b506adce16af75fd0b71 100644

--- a/chrome/browser/history/history_service.h

+++ b/chrome/browser/history/history_service.h

@@ -615,6 +615,13 @@ class HistoryService : public content::NotificationObserver,

// HistoryService is being deleted.

void NotifyHistoryServiceBeingDeleted();

+ // Notify all HistoryServicerObservs registered that keyword have be searched

nshaik 2014/12/30 18:56:35 nit: HistoryServiceObservers

nshaik 2014/12/30 18:56:35 nit:keyword has "to" be searched

Abhishek 2014/12/31 05:57:22 Done.

+ // using omnibox. |row| contains the URL information for search |term|.

+ // |keyword_id| associated with a URL and search term.

+ void NotifyKeywordSearchTermUpdated(const history::URLRow& row,

+ history::KeywordID keyword_id,

+ const base::string16& term);

// Favicon -------------------------------------------------------------------

// These favicon methods are exposed to the FaviconService. Instead of calling