Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: chrome/browser/history/history_service.h

Issue 808123003: Eliminate sending NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: inline code for provider class Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
6 #define CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 597 matching lines...) Expand 10 before | Expand all | Expand 10 after
608 // modified. |changed_urls| contains the list of affects URLs. 608 // modified. |changed_urls| contains the list of affects URLs.
609 void NotifyURLsModified(const history::URLRows& changed_urls); 609 void NotifyURLsModified(const history::URLRows& changed_urls);
610 610
611 // Notify all HistoryServiceObservers registered that the 611 // Notify all HistoryServiceObservers registered that the
612 // HistoryService has finished loading. 612 // HistoryService has finished loading.
613 void NotifyHistoryServiceLoaded(); 613 void NotifyHistoryServiceLoaded();
614 614
615 // HistoryService is being deleted. 615 // HistoryService is being deleted.
616 void NotifyHistoryServiceBeingDeleted(); 616 void NotifyHistoryServiceBeingDeleted();
617 617
618 // Notify all HistoryServicerObservs registered that keyword have be searched
nshaik 2014/12/30 18:56:35 nit: HistoryServiceObservers
nshaik 2014/12/30 18:56:35 nit:keyword has "to" be searched
Abhishek 2014/12/31 05:57:22 Done.
619 // using omnibox. |row| contains the URL information for search |term|.
620 // |keyword_id| associated with a URL and search term.
621 void NotifyKeywordSearchTermUpdated(const history::URLRow& row,
622 history::KeywordID keyword_id,
623 const base::string16& term);
624
618 // Favicon ------------------------------------------------------------------- 625 // Favicon -------------------------------------------------------------------
619 626
620 // These favicon methods are exposed to the FaviconService. Instead of calling 627 // These favicon methods are exposed to the FaviconService. Instead of calling
621 // these methods directly you should call the respective method on the 628 // these methods directly you should call the respective method on the
622 // FaviconService. 629 // FaviconService.
623 630
624 // Used by FaviconService to get the favicon bitmaps from the history backend 631 // Used by FaviconService to get the favicon bitmaps from the history backend
625 // whose edge sizes most closely match |desired_sizes| for |icon_types|. If 632 // whose edge sizes most closely match |desired_sizes| for |icon_types|. If
626 // |desired_sizes| has a '0' entry, the largest favicon bitmap for 633 // |desired_sizes| has a '0' entry, the largest favicon bitmap for
627 // |icon_types| is returned. The returned FaviconBitmapResults will have at 634 // |icon_types| is returned. The returned FaviconBitmapResults will have at
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
905 912
906 history::DeleteDirectiveHandler delete_directive_handler_; 913 history::DeleteDirectiveHandler delete_directive_handler_;
907 914
908 // All vended weak pointers are invalidated in Cleanup(). 915 // All vended weak pointers are invalidated in Cleanup().
909 base::WeakPtrFactory<HistoryService> weak_ptr_factory_; 916 base::WeakPtrFactory<HistoryService> weak_ptr_factory_;
910 917
911 DISALLOW_COPY_AND_ASSIGN(HistoryService); 918 DISALLOW_COPY_AND_ASSIGN(HistoryService);
912 }; 919 };
913 920
914 #endif // CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_ 921 #endif // CHROME_BROWSER_HISTORY_HISTORY_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698