Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(678)

Issue 8081014: Initialize and set compositor thread in WebKit initialization (Closed)

Created:
8 years, 8 months ago by jamesr
Modified:
8 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, nduca
Visibility:
Public.

Description

Initialize and set compositor thread in WebKit initialization Chromium side to https://bugs.webkit.org/show_bug.cgi?id=69117 BUG= TEST=

Patch Set 1 #

Total comments: 1

Patch Set 2 : initialize WebThreadImpl directly #

Total comments: 2

Patch Set 3 : for landing #

Patch Set 4 : WebThreadImpl is in a namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/renderer/render_thread.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/render_thread.cc View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jamesr
8 years, 8 months ago (2011-09-30 02:04:52 UTC) #1
jam
http://codereview.chromium.org/8081014/diff/1/content/renderer/render_thread.cc File content/renderer/render_thread.cc (right): http://codereview.chromium.org/8081014/diff/1/content/renderer/render_thread.cc#newcode448 content/renderer/render_thread.cc:448: webkit_platform_support_->createThread("Compositor")); nit: it's a little odd that the webkit ...
8 years, 8 months ago (2011-09-30 02:50:58 UTC) #2
jamesr
Oh yeah - guess I could do that :)
8 years, 8 months ago (2011-09-30 02:55:04 UTC) #3
darin (slow to review)
LGTM http://codereview.chromium.org/8081014/diff/2002/content/renderer/render_thread.h File content/renderer/render_thread.h (right): http://codereview.chromium.org/8081014/diff/2002/content/renderer/render_thread.h#newcode280 content/renderer/render_thread.h:280: scoped_ptr<WebKit::WebThread> compositor_thread_; This may be better as a ...
8 years, 8 months ago (2011-09-30 06:05:15 UTC) #4
darin (slow to review)
http://codereview.chromium.org/8081014/diff/2002/content/renderer/render_thread.cc File content/renderer/render_thread.cc (right): http://codereview.chromium.org/8081014/diff/2002/content/renderer/render_thread.cc#newcode67 content/renderer/render_thread.cc:67: #include "third_party/WebKit/Source/WebKit/chromium/public/WebThread.h" nit: this include should be unnecessary
8 years, 8 months ago (2011-09-30 06:06:06 UTC) #5
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/8081014/6001
8 years, 8 months ago (2011-09-30 06:59:21 UTC) #6
darin (slow to review)
8 years, 8 months ago (2011-09-30 16:27:32 UTC) #7
No need to land this.  I have built on this approach locally.  Will upload a
patch soon.

Powered by Google App Engine
This is Rietveld 408576698