Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 808053007: Record whether a SSL warning is caused by a self-signed cert (Closed)

Created:
5 years, 11 months ago by felt
Modified:
5 years, 11 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record whether a SSL warning is caused by a self-signed cert This adds the UMA call to record when SSL warnings are caused by self- signed certs. It also updates the histogram name: SSLNonAttackCauses is no longer an appropriate name because a self-signed cert very well might be an attack. BUG=392310 R=palmer@chromium.org Committed: https://crrev.com/05b83de45a179f95fca6c4c1bf08142f93268451 Cr-Commit-Position: refs/heads/master@{#311362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -32 lines) Patch
M chrome/browser/ssl/ssl_error_classification.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 4 chunks +34 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
felt
Chris, Alexei, please review. Chris: I'm really sorry to not have landed this a long ...
5 years, 11 months ago (2015-01-13 22:19:03 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 11 months ago (2015-01-13 22:38:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808053007/1
5 years, 11 months ago (2015-01-13 22:39:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 23:47:53 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 23:48:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05b83de45a179f95fca6c4c1bf08142f93268451
Cr-Commit-Position: refs/heads/master@{#311362}

Powered by Google App Engine
This is Rietveld 408576698