Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4238)

Unified Diff: chrome/browser/ssl/ssl_error_classification.cc

Issue 808053007: Record whether a SSL warning is caused by a self-signed cert (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_error_classification.cc
diff --git a/chrome/browser/ssl/ssl_error_classification.cc b/chrome/browser/ssl/ssl_error_classification.cc
index a8c1806ee3b1323d4fcfc0ab65b82c9273835ad1..324bc18eced1f735bf0890fa61f5b395cbd68903 100644
--- a/chrome/browser/ssl/ssl_error_classification.cc
+++ b/chrome/browser/ssl/ssl_error_classification.cc
@@ -53,6 +53,7 @@ enum SSLInterstitialCause {
LOCALHOST,
PRIVATE_URL,
AUTHORITY_ERROR_CAPTIVE_PORTAL,
+ SELF_SIGNED,
UNUSED_INTERSTITIAL_CAUSE_ENTRY,
};
@@ -334,6 +335,8 @@ void SSLErrorClassification::RecordUMAStatistics(
RecordSSLInterstitialCause(overridable, PRIVATE_URL);
if (captive_portal_probe_completed_ && captive_portal_detected_)
RecordSSLInterstitialCause(overridable, AUTHORITY_ERROR_CAPTIVE_PORTAL);
+ if (net::X509Certificate::IsSelfSigned(cert_.os_cert_handle()))
+ RecordSSLInterstitialCause(overridable, SELF_SIGNED);
break;
}
default:
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698