Issue 807993002: Ensure that AnalysisContext futures are completed when context disposed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 807993002: Ensure that AnalysisContext futures are completed when context disposed. (Closed)

Created:
6 years ago by Paul Berry

Modified:
6 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Ensure that AnalysisContext futures are completed when context disposed. It's possible for the analysis server to create or destroy contexts in the background while the user is working (as a result of changes on the filesystem). This ensures that if any code completions are waiting for analysis when that happens, they are aborted. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=42416

Patch Set 1 #

Patch Set 2 : Handle case of computeAsync called after dispose #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -74 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analysis_server/test/analysis_server_test.dart	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/engine_test.dart	View	1	2 chunks	+131 lines, -74 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

6 years ago (2014-12-16 23:42:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 42416 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages