pkg/analysis_server/lib/src/analysis_server.dart - Issue 807993002: Ensure that AnalysisContext futures are completed when context disposed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 807993002: Ensure that AnalysisContext futures are completed when context disposed. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Handle case of computeAsync called after dispose Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/analysis_server.dart

diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart

index 47291809e16447a5eb0e6e77d55e1787ba938f5f..7b32c0a04d736934014eab8790571bef1eb9e9ca 100644

--- a/pkg/analysis_server/lib/src/analysis_server.dart

+++ b/pkg/analysis_server/lib/src/analysis_server.dart

@@ -1042,6 +1042,7 @@ class ServerContextManager extends ContextManager {

analysisServer.sendContextAnalysisDoneNotifications(

context,

AnalysisDoneReason.CONTEXT_REMOVED);

+ context.dispose();

}

@override

« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis_server_test.dart » ('j') | no next file with comments »