Issue 807873002: Correct 'string literal' to 'primitive strings'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 807873002: Correct 'string literal' to 'primitive strings' (Closed)

Created:
6 years ago by eseidel

Modified:
6 years ago

Reviewers:
hansmuller

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Correct 'string literal' to 'primitive strings' Per request in: https://codereview.chromium.org/803173003/#msg6 String literals are not the only strings with typeof(s) == 'string'. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String R=hansmuller@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/42619d2ba9408a24fed93f47137108cb36dece8f

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mojo/public/js/codec.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

6 years ago (2014-12-16 17:22:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
42619d2ba9408a24fed93f47137108cb36dece8f (presubmit successful).

Expand Messages | Collapse Messages