mojo/public/js/codec.js - Issue 807873002: Correct 'string literal' to 'primitive strings'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/js/codec.js

Issue 807873002: Correct 'string literal' to 'primitive strings' (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/js/codec.js

diff --git a/mojo/public/js/codec.js b/mojo/public/js/codec.js

index f071d2f870923c6cd2202f7a692b3a17d853c140..d987026ebf94facdbd5e68ffb850bb59f04a4c17 100644

--- a/mojo/public/js/codec.js

+++ b/mojo/public/js/codec.js

@@ -371,7 +371,7 @@ define("mojo/public/js/codec", [

this.encodePointer(val);

return;

}

- // This only accepts string literals, not objects like new String("foo").

+ // Only accepts string primivites, not String Objects like new String("foo")

if (typeof(val) !== "string") {

throw new Error(kErrorString);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »