Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 807693003: [turbofan] Unify custom node matchers.

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Unify custom node matchers. Also clean up the JSInliner class and friends. TEST=cctest/test-run-inlining,cctest/test-run-intrinsics

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix Win64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -183 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-inlining.h View 1 chunk +40 lines, -19 lines 0 comments Download
M src/compiler/js-inlining.cc View 5 chunks +76 lines, -150 lines 0 comments Download
M src/compiler/node.h View 1 4 chunks +30 lines, -13 lines 0 comments Download
M src/compiler/node-matchers.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/compiler/node-matchers.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Benedikt Meurer
PTAL
6 years ago (2014-12-23 09:57:08 UTC) #2
jochen (gone - plz use gerrit)
6 years ago (2014-12-23 10:38:42 UTC) #3
sorry, I have a hard time figuring out what this CL does :-/

https://codereview.chromium.org/807693003/diff/1/src/compiler/node-matchers.h
File src/compiler/node-matchers.h (right):

https://codereview.chromium.org/807693003/diff/1/src/compiler/node-matchers.h...
src/compiler/node-matchers.h:208: struct JSCallFunctionMatcher FINAL : public
NodeMatcher {
i see that this is done all over the place, but these shouldn't be structs...

https://codereview.chromium.org/807693003/diff/1/src/compiler/node-matchers.h...
src/compiler/node-matchers.h:227: };
are you copying the matchers around? If yes, there should be explicit
copy/assignment operators, if not, the DISALLOW_COPY_AND_ASSIGN() macro should
be used

Powered by Google App Engine
This is Rietveld 408576698