[turbofan] Unify custom node matchers.

src/compiler/node-matchers.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_NODE_MATCHERS_H_
 #define V8_COMPILER_NODE_MATCHERS_H_
 
 #include <cmath>
 
 #include "src/compiler/node.h"
@@ skipping 186 matching lines @@
 typedef BinopMatcher<Int32Matcher, Int32Matcher> Int32BinopMatcher;
 typedef BinopMatcher<Uint32Matcher, Uint32Matcher> Uint32BinopMatcher;
 typedef BinopMatcher<Int64Matcher, Int64Matcher> Int64BinopMatcher;
 typedef BinopMatcher<Uint64Matcher, Uint64Matcher> Uint64BinopMatcher;
 typedef BinopMatcher<IntPtrMatcher, IntPtrMatcher> IntPtrBinopMatcher;
 typedef BinopMatcher<UintPtrMatcher, UintPtrMatcher> UintPtrBinopMatcher;
 typedef BinopMatcher<Float64Matcher, Float64Matcher> Float64BinopMatcher;
 typedef BinopMatcher<NumberMatcher, NumberMatcher> NumberBinopMatcher;
 
 
+// A pattern matcher for JSCallFunction operations.
+struct JSCallFunctionMatcher FINAL : public NodeMatcher {

[jochen (gone - plz use gerrit), 2014/12/23 10:38:42]

i see that this is done all over the place, but these shouldn't be structs...

+  explicit JSCallFunctionMatcher(Node* const node)
+      : NodeMatcher(node), function_(node->InputAt(0)) {
+    DCHECK_EQ(IrOpcode::kJSCallFunction, opcode());
+  }
+
+  typedef HeapObjectMatcher<JSFunction> Function;
+
+  const Function& function() const { return function_; }
+  Node* frame_state() const;
+
+  // Formal parameters, including the receiver.
+  typedef Node::Inputs::iterator const_iterator;
+  const_iterator begin() const;
+  const_iterator end() const;
+  size_t size() const;
+
+ private:
+  Function const function_;
+};

[jochen (gone - plz use gerrit), 2014/12/23 10:38:42]

are you copying the matchers around? If yes, there should be explicit
copy/assignment operators, if not, the DISALLOW_COPY_AND_ASSIGN() macro should
be used

+
+
+// A pattern matcher for JSCallRuntime operations.
+struct JSCallRuntimeMatcher FINAL : public NodeMatcher {
+  explicit JSCallRuntimeMatcher(Node* const node) : NodeMatcher(node) {
+    DCHECK_EQ(IrOpcode::kJSCallRuntime, opcode());
+  }
+
+  const Runtime::Function* function() const;
+};
+
+
 template <class BinopMatcher, IrOpcode::Value kMulOpcode,
           IrOpcode::Value kShiftOpcode>
 struct ScaleMatcher {
   explicit ScaleMatcher(Node* node, bool allow_power_of_two_plus_one = false)
       : scale_(-1), power_of_two_plus_one_(false) {
     if (node->InputCount() < 2) return;
     BinopMatcher m(node);
     if (node->opcode() == kShiftOpcode) {
       if (m.right().HasValue()) {
         typename BinopMatcher::RightMatcher::ValueType value =
@@ skipping 292 matching lines @@
 typedef BaseWithIndexAndDisplacementMatcher<Int32AddMatcher>
     BaseWithIndexAndDisplacement32Matcher;
 typedef BaseWithIndexAndDisplacementMatcher<Int64AddMatcher>
     BaseWithIndexAndDisplacement64Matcher;
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_NODE_MATCHERS_H_