Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 807593003: Revert of Update extensions::MessagingBindings to use WebScopedWindowFocusAllowedIndicator with... (Closed)

Created:
6 years ago by Ken Rockot(use gerrit already)
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Mike West, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Update extensions::MessagingBindings to use WebScopedWindowFocusAllowedIndicator with WebDocument. (patchset #1 id:1 of https://codereview.chromium.org/786403003/) Reason for revert: This CL or its dependency in blink (https://codereview.chromium.org/803253003/) is the suspected source of issue 441968 (very prominent renderer crash), among other crashes. Original issue's description: > Update extensions::MessagingBindings to use WebScopedWindowFocusAllowedIndicator with WebDocument. > > This will allow Blink to delete some deprecated code. > > This is part of a three-sided CL: > Part 1: https://codereview.chromium.org/777483004/ > Part 2: <this> > Part 3: https://codereview.chromium.org/722423004 > > BUG=440740 > > Committed: https://crrev.com/ebb4bf8090b06979fd44411af69304b505681f4d > Cr-Commit-Position: refs/heads/master@{#307914} TBR=scheib@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=440740 Committed: https://crrev.com/7e0846da8d2da2c0cda56af8c180bcdefb08c046 Cr-Commit-Position: refs/heads/master@{#308506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M extensions/renderer/messaging_bindings.cc View 4 chunks +11 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Ken Rockot(use gerrit already)
Created Revert of Update extensions::MessagingBindings to use WebScopedWindowFocusAllowedIndicator with WebDocument.
6 years ago (2014-12-16 02:27:17 UTC) #1
Ken Rockot(use gerrit already)
6 years ago (2014-12-16 02:37:28 UTC) #3
Message was sent while issue was closed.
CL isn't being updated for some reason (think it's a rietveld bug with subject
length), but this has landed. +amineer FYI

Powered by Google App Engine
This is Rietveld 408576698