Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 807513003: Switch ExitCodeWatcher to base::Process. (Closed)

Created:
6 years ago by Sigurður Ásgeirsson
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch ExitCodeWatcher to base::Process. R=erikwright@chromium.org BUG=412384 Committed: https://crrev.com/581938f0351e10aed206ce295d4504eb5cd611a6 Cr-Commit-Position: refs/heads/master@{#309073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -58 lines) Patch
M chrome/chrome_watcher/chrome_watcher_main.cc View 2 chunks +4 lines, -21 lines 0 comments Download
M components/browser_watcher/exit_code_watcher_win.h View 3 chunks +3 lines, -4 lines 0 comments Download
M components/browser_watcher/exit_code_watcher_win.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M components/browser_watcher/exit_code_watcher_win_unittest.cc View 6 chunks +24 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
erikwright (departed)
LGTM (reviewed a previous incarnation).
6 years ago (2014-12-18 20:22:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807513003/1
6 years ago (2014-12-18 20:24:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 21:17:27 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-18 21:18:43 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/581938f0351e10aed206ce295d4504eb5cd611a6
Cr-Commit-Position: refs/heads/master@{#309073}

Powered by Google App Engine
This is Rietveld 408576698