Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Side by Side Diff: components/browser_watcher/exit_code_watcher_win.h

Issue 807513003: Switch ExitCodeWatcher to base::Process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 #ifndef COMPONENTS_BROWSER_WATCHER_EXIT_CODE_WATCHER_WIN_H_ 4 #ifndef COMPONENTS_BROWSER_WATCHER_EXIT_CODE_WATCHER_WIN_H_
5 #define COMPONENTS_BROWSER_WATCHER_EXIT_CODE_WATCHER_WIN_H_ 5 #define COMPONENTS_BROWSER_WATCHER_EXIT_CODE_WATCHER_WIN_H_
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/process/process_handle.h" 8 #include "base/process/process.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 #include "base/win/scoped_handle.h" 11 #include "base/win/scoped_handle.h"
12 12
13 namespace base { 13 namespace base {
14 class CommandLine; 14 class CommandLine;
15 } 15 }
16 16
17 namespace browser_watcher { 17 namespace browser_watcher {
18 18
(...skipping 14 matching lines...) Expand all
33 // the process exit code. 33 // the process exit code.
34 // It checks the handle for validity and takes ownership of it. 34 // It checks the handle for validity and takes ownership of it.
35 // The intent is for this handle to be inherited into the watcher process 35 // The intent is for this handle to be inherited into the watcher process
36 // hosting the instance of this class. 36 // hosting the instance of this class.
37 bool ParseArguments(const base::CommandLine& cmd_line); 37 bool ParseArguments(const base::CommandLine& cmd_line);
38 38
39 // Waits for the process to exit and records its exit code in registry. 39 // Waits for the process to exit and records its exit code in registry.
40 // This is a blocking call. 40 // This is a blocking call.
41 void WaitForExit(); 41 void WaitForExit();
42 42
43 base::ProcessHandle process() const { return process_.Get(); } 43 const base::Process& process() const { return process_; }
44 44
45 private: 45 private:
46 // Writes |exit_code| to registry, returns true on success. 46 // Writes |exit_code| to registry, returns true on success.
47 bool WriteProcessExitCode(int exit_code); 47 bool WriteProcessExitCode(int exit_code);
48 48
49 // The registry path the exit codes are written to. 49 // The registry path the exit codes are written to.
50 base::string16 registry_path_; 50 base::string16 registry_path_;
51 51
52 // Handle, PID, and creation time of the watched process. 52 // Handle, PID, and creation time of the watched process.
53 base::win::ScopedHandle process_; 53 base::Process process_;
54 base::ProcessId process_pid_;
55 base::Time process_creation_time_; 54 base::Time process_creation_time_;
56 55
57 DISALLOW_COPY_AND_ASSIGN(ExitCodeWatcher); 56 DISALLOW_COPY_AND_ASSIGN(ExitCodeWatcher);
58 }; 57 };
59 58
60 } // namespace browser_watcher 59 } // namespace browser_watcher
61 60
62 #endif // COMPONENTS_BROWSER_WATCHER_EXIT_CODE_WATCHER_WIN_H_ 61 #endif // COMPONENTS_BROWSER_WATCHER_EXIT_CODE_WATCHER_WIN_H_
OLDNEW
« no previous file with comments | « chrome/chrome_watcher/chrome_watcher_main.cc ('k') | components/browser_watcher/exit_code_watcher_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698