Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 807423003: Remove CompositorUtilTest (Closed)

Created:
6 years ago by zhaoze.zhou
Modified:
6 years ago
Reviewers:
Zhenyao Mo, brettw, gab
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CompositorUtilTest The #if defined(USE_AURA) || defined(OS_ANDROID) || defined(OS_MACOSX) is a always true guard, the expected_mode will always be DELEGATED. This cl will remove this test case because it didn't make sense. BUG=None Committed: https://crrev.com/ce0415e9693c1a520c418c93b47bb5dcce8cce37 Cr-Commit-Position: refs/heads/master@{#309052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
D content/browser/gpu/compositor_util_browsertest.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
zhaoze.zhou
PTAL. thanks.
6 years ago (2014-12-17 22:58:41 UTC) #3
brettw
I think you have too many reviewers. Please say who you expect to do a ...
6 years ago (2014-12-17 23:31:43 UTC) #4
zhaoze.zhou
On 2014/12/17 23:31:43, brettw wrote: > I think you have too many reviewers. Please say ...
6 years ago (2014-12-17 23:57:34 UTC) #6
gab
lgtm as it indeed looks like this test is no longer useful, but I'm far ...
6 years ago (2014-12-18 15:30:12 UTC) #8
Zhenyao Mo
LGTM
6 years ago (2014-12-18 18:20:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807423003/1
6 years ago (2014-12-18 18:41:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 19:18:25 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-18 19:19:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce0415e9693c1a520c418c93b47bb5dcce8cce37
Cr-Commit-Position: refs/heads/master@{#309052}

Powered by Google App Engine
This is Rietveld 408576698