Remove EnableThreadedCompositing from the browser.

Remove EnableThreadedCompositing from the browser.

Now only --disable-threaded-compositing exists, which is only present
for layout tests. The --enable-threaded-compositing flag moves to
become a content shell flag only, as it's only used for DumpRenderTree.

Change any checks in the renderer process for kEnableThreadedCompositing
to instead be !kDisableThreadedCompositing since that is the only
flag left.

Remove the whole threaded compositing thing from about:gpu and
about:flags.

R=piman
BUG=384381, 346363
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278151

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283870

[piman, 2014-06-13 20:55:19]

lgtm

https://codereview.chromium.org/337783002/diff/60001/content/browser/renderer...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/337783002/diff/60001/content/browser/renderer...
content/browser/renderer_host/render_process_host_impl.cc:1114:
switches::kDisableThreadedCompositing,
Is there a way to explicitly give this flag to the renderer in the layout tests
infra, instead of allowing this to be passed from the browser command line?

https://codereview.chromium.org/337783002/diff/60001/content/renderer/render_...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/337783002/diff/60001/content/renderer/render_...
content/renderer/render_widget.cc:407: switches::kDisableThreadedCompositing);
nit: can we test from !!RenderThreadImpl::Get()->compositor_message_loop_proxy()
so that the logic is in a single place?

[danakj, 2014-06-13 20:57:29]

https://codereview.chromium.org/337783002/diff/60001/content/browser/renderer...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/337783002/diff/60001/content/browser/renderer...
content/browser/renderer_host/render_process_host_impl.cc:1114:
switches::kDisableThreadedCompositing,
On 2014/06/13 20:55:19, piman wrote:
> Is there a way to explicitly give this flag to the renderer in the layout
tests
> infra, instead of allowing this to be passed from the browser command line?

Uhmmm, idk! Hmm maybe something like EnableRendererLayoutTestMode() does.

[piman, 2014-06-13 21:05:09]

On 2014/06/13 20:57:29, danakj wrote:
>
https://codereview.chromium.org/337783002/diff/60001/content/browser/renderer...
> File content/browser/renderer_host/render_process_host_impl.cc (right):
> 
>
https://codereview.chromium.org/337783002/diff/60001/content/browser/renderer...
> content/browser/renderer_host/render_process_host_impl.cc:1114:
> switches::kDisableThreadedCompositing,
> On 2014/06/13 20:55:19, piman wrote:
> > Is there a way to explicitly give this flag to the renderer in the layout
> tests
> > infra, instead of allowing this to be passed from the browser command line?
> 
> Uhmmm, idk! Hmm maybe something like EnableRendererLayoutTestMode() does.

If it's possible. If it's too hard, this is ok.

[danakj, 2014-06-13 21:46:36]

https://codereview.chromium.org/337783002/diff/60001/content/browser/renderer...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/337783002/diff/60001/content/browser/renderer...
content/browser/renderer_host/render_process_host_impl.cc:1114:
switches::kDisableThreadedCompositing,
On 2014/06/13 20:57:28, danakj wrote:
> On 2014/06/13 20:55:19, piman wrote:
> > Is there a way to explicitly give this flag to the renderer in the layout
> tests
> > infra, instead of allowing this to be passed from the browser command line?
> 
> Uhmmm, idk! Hmm maybe something like EnableRendererLayoutTestMode() does.

Hm, I could wire it differently in the renderer/check for this flag in shell
instead of render thread, but I think we still need to pass the flag, or at
least, I don't know any special browser->renderer process data passing mechanism
specially for content shell..

https://codereview.chromium.org/337783002/diff/60001/content/renderer/render_...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/337783002/diff/60001/content/renderer/render_...
content/renderer/render_widget.cc:407: switches::kDisableThreadedCompositing);
On 2014/06/13 20:55:19, piman wrote:
> nit: can we test from
!!RenderThreadImpl::Get()->compositor_message_loop_proxy()
> so that the logic is in a single place?

Done.

[danakj, 2014-06-13 21:46:40]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-06-13 21:49:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/337783002/80001

[piman, 2014-06-13 21:56:42]

https://codereview.chromium.org/337783002/diff/80001/content/renderer/render_...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/337783002/diff/80001/content/renderer/render_...
content/renderer/render_widget.cc:152: return
!!content::RenderThreadImpl::current()
Oh, iirc there's a couple of tests that mock RenderThread - this returns NULL,
that you may need to defend against.

[danakj, 2014-06-13 21:58:52]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-06-13 21:58:54]

https://codereview.chromium.org/337783002/diff/80001/content/renderer/render_...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/337783002/diff/80001/content/renderer/render_...
content/renderer/render_widget.cc:152: return
!!content::RenderThreadImpl::current()
On 2014/06/13 21:56:42, piman wrote:
> Oh, iirc there's a couple of tests that mock RenderThread - this returns NULL,
> that you may need to defend against.

Oh thanks, done.

[commit-bot: I haz the power, 2014-06-13 22:02:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/337783002/100001

[piman, 2014-06-13 22:07:18]

https://codereview.chromium.org/337783002/diff/100001/content/renderer/render...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/337783002/diff/100001/content/renderer/render...
content/renderer/render_widget.cc:153: return !impl ||
!!impl->compositor_message_loop_proxy().get();
I think it should be impl && !!impl->compositor_message_loop_proxy().get()

If we don't have RenderThreadImpl, we don't have a thread... See also
RenderWidgetCompositor::Initialize

[commit-bot: I haz the power, 2014-06-14 06:12:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-14 06:12:03]

Try jobs failed on following builders:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)

[danakj, 2014-06-16 16:14:14]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-06-16 16:14:56]

Ok going to do impl && impl->compositorthreadproxy() for now. I'll look at doing
nicer plumbing and getting tests to work without a single thread proxy in a
followup.

[commit-bot: I haz the power, 2014-06-16 16:15:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/337783002/120001

[commit-bot: I haz the power, 2014-06-16 20:54:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 20:54:28]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[danakj, 2014-06-17 20:06:37]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-06-17 20:08:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/337783002/140001

[commit-bot: I haz the power, 2014-06-18 02:26:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-18 02:26:38]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[danakj, 2014-06-18 15:34:25]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-06-18 15:35:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/337783002/160001

[commit-bot: I haz the power, 2014-06-18 16:17:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-18 16:17:20]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/18413)

[danakj, 2014-06-18 16:21:13]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-06-18 16:24:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/337783002/180001

[commit-bot: I haz the power, 2014-06-18 19:50:10]

Change committed as 278151

[danakj, 2014-06-18 21:05:34]

A revert of this CL has been created in
https://codereview.chromium.org/344703002/ by danakj@chromium.org.

The reason for reverting is: Broke virtual/threaded, made them use single
threaded compositor (and impl side painting)..

[danakj, 2014-07-17 17:32:15]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-07-17 17:33:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/337783002/250001

[commit-bot: I haz the power, 2014-07-17 21:06:57]

Change committed as 283870