Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 807193003: Re-apply "Remove unittest and matcher from the repo." (Closed)

Created:
6 years ago by nweiz
Modified:
6 years ago
CC:
reviews_dartlang.org, ricow1, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Re-apply "Remove unittest and matcher from the repo." This was originally submitted as r42497 and reverted by r42498. This CL fixes the failing isolate test, and https://codereview.chromium.org/814883003/ fixes the Dartium and Standalone issues. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=42524

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8372 lines) Patch
D pkg/matcher/CHANGELOG.md View 1 chunk +0 lines, -55 lines 0 comments Download
D pkg/matcher/LICENSE View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/matcher/README.md View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/matcher/lib/matcher.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D pkg/matcher/lib/mirror_matchers.dart View 1 chunk +0 lines, -76 lines 0 comments Download
D pkg/matcher/lib/src/core_matchers.dart View 1 chunk +0 lines, -657 lines 0 comments Download
D pkg/matcher/lib/src/description.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D pkg/matcher/lib/src/error_matchers.dart View 1 chunk +0 lines, -102 lines 0 comments Download
D pkg/matcher/lib/src/expect.dart View 1 chunk +0 lines, -177 lines 0 comments Download
D pkg/matcher/lib/src/future_matchers.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D pkg/matcher/lib/src/interfaces.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D pkg/matcher/lib/src/iterable_matchers.dart View 1 chunk +0 lines, -266 lines 0 comments Download
D pkg/matcher/lib/src/map_matchers.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D pkg/matcher/lib/src/numeric_matchers.dart View 1 chunk +0 lines, -213 lines 0 comments Download
D pkg/matcher/lib/src/operator_matchers.dart View 1 chunk +0 lines, -123 lines 0 comments Download
D pkg/matcher/lib/src/pretty_print.dart View 1 chunk +0 lines, -147 lines 0 comments Download
D pkg/matcher/lib/src/prints_matcher.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D pkg/matcher/lib/src/string_matchers.dart View 1 chunk +0 lines, -203 lines 0 comments Download
D pkg/matcher/lib/src/throws_matcher.dart View 1 chunk +0 lines, -113 lines 0 comments Download
D pkg/matcher/lib/src/throws_matchers.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D pkg/matcher/lib/src/util.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D pkg/matcher/pubspec.yaml View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/matcher/test/core_matchers_test.dart View 1 chunk +0 lines, -179 lines 0 comments Download
D pkg/matcher/test/future_matchers_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download
D pkg/matcher/test/iterable_matchers_test.dart View 1 chunk +0 lines, -171 lines 0 comments Download
D pkg/matcher/test/matchers_minified_test.dart View 1 chunk +0 lines, -145 lines 0 comments Download
D pkg/matcher/test/matchers_unminified_test.dart View 1 chunk +0 lines, -142 lines 0 comments Download
D pkg/matcher/test/mirror_matchers_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D pkg/matcher/test/numeric_matchers_test.dart View 1 chunk +0 lines, -152 lines 0 comments Download
D pkg/matcher/test/operator_matchers_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D pkg/matcher/test/pretty_print_minified_test.dart View 1 chunk +0 lines, -64 lines 0 comments Download
D pkg/matcher/test/pretty_print_test.dart View 1 chunk +0 lines, -199 lines 0 comments Download
D pkg/matcher/test/pretty_print_unminified_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D pkg/matcher/test/prints_matcher_test.dart View 1 chunk +0 lines, -107 lines 0 comments Download
D pkg/matcher/test/string_matchers_test.dart View 1 chunk +0 lines, -101 lines 0 comments Download
D pkg/matcher/test/test_common.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D pkg/matcher/test/test_utils.dart View 1 chunk +0 lines, -82 lines 0 comments Download
D pkg/matcher/test/throws_matchers_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download
M pkg/pkg.status View 8 chunks +0 lines, -60 lines 0 comments Download
D pkg/unittest/CHANGELOG.md View 1 chunk +0 lines, -103 lines 0 comments Download
D pkg/unittest/LICENSE View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/unittest/lib/compact_vm_config.dart View 1 chunk +0 lines, -216 lines 0 comments Download
D pkg/unittest/lib/coverage_controller.js View 1 chunk +0 lines, -31 lines 0 comments Download
D pkg/unittest/lib/html_config.dart View 1 chunk +0 lines, -176 lines 0 comments Download
D pkg/unittest/lib/html_enhanced_config.dart View 1 chunk +0 lines, -417 lines 0 comments Download
D pkg/unittest/lib/html_individual_config.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D pkg/unittest/lib/src/configuration.dart View 1 chunk +0 lines, -69 lines 0 comments Download
D pkg/unittest/lib/src/group_context.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D pkg/unittest/lib/src/simple_configuration.dart View 1 chunk +0 lines, -199 lines 0 comments Download
D pkg/unittest/lib/src/spread_args_helper.dart View 1 chunk +0 lines, -166 lines 0 comments Download
D pkg/unittest/lib/src/test_case.dart View 1 chunk +0 lines, -191 lines 0 comments Download
D pkg/unittest/lib/src/test_environment.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D pkg/unittest/lib/src/utils.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D pkg/unittest/lib/test_controller.js View 1 chunk +0 lines, -233 lines 0 comments Download
D pkg/unittest/lib/unittest.dart View 1 chunk +0 lines, -601 lines 0 comments Download
D pkg/unittest/lib/vm_config.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D pkg/unittest/pubspec.yaml View 1 chunk +0 lines, -16 lines 0 comments Download
D pkg/unittest/test/async_exception_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D pkg/unittest/test/async_exception_with_future_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D pkg/unittest/test/async_setup_teardown_test.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D pkg/unittest/test/breath_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D pkg/unittest/test/completion_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D pkg/unittest/test/correct_callback_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/unittest/test/exception_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/unittest/test/excess_callback_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D pkg/unittest/test/expect_async_args_test.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D pkg/unittest/test/expect_async_test.dart View 1 chunk +0 lines, -100 lines 0 comments Download
D pkg/unittest/test/group_name_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D pkg/unittest/test/invalid_ops_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/unittest/test/late_exception_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D pkg/unittest/test/middle_exception_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D pkg/unittest/test/missing_tick_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/unittest/test/nested_groups_setup_teardown_test.dart View 1 chunk +0 lines, -65 lines 0 comments Download
D pkg/unittest/test/protect_async_test.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D pkg/unittest/test/returning_future_test.dart View 1 chunk +0 lines, -74 lines 0 comments Download
D pkg/unittest/test/returning_future_using_runasync_test.dart View 1 chunk +0 lines, -91 lines 0 comments Download
D pkg/unittest/test/runtests_without_tests_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D pkg/unittest/test/setup_and_teardown_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D pkg/unittest/test/setup_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/unittest/test/single_correct_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D pkg/unittest/test/single_failing_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D pkg/unittest/test/skipped_soloed_nested_test.dart View 1 chunk +0 lines, -89 lines 0 comments Download
D pkg/unittest/test/teardown_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D pkg/unittest/test/testcases_immutable_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D pkg/unittest/test/with_test_environment_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download
M site/try/build_try.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/port_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
nweiz
6 years ago (2014-12-19 19:19:42 UTC) #2
kevmoo
DBC https://codereview.chromium.org/807193003/diff/1/tests/isolate/port_test.dart File tests/isolate/port_test.dart (right): https://codereview.chromium.org/807193003/diff/1/tests/isolate/port_test.dart#newcode14 tests/isolate/port_test.dart:14: import 'package:matcher/matcher.dart'; Better yet: remove this. Matcher is ...
6 years ago (2014-12-19 19:24:55 UTC) #4
nweiz
Code review changes
6 years ago (2014-12-19 20:12:51 UTC) #5
nweiz
https://codereview.chromium.org/807193003/diff/1/tests/isolate/port_test.dart File tests/isolate/port_test.dart (right): https://codereview.chromium.org/807193003/diff/1/tests/isolate/port_test.dart#newcode14 tests/isolate/port_test.dart:14: import 'package:matcher/matcher.dart'; On 2014/12/19 19:24:54, kevmoo wrote: > Better ...
6 years ago (2014-12-19 20:13:04 UTC) #6
Siggi Cherem (dart-lang)
lgtm
6 years ago (2014-12-19 20:53:36 UTC) #7
nweiz
6 years ago (2014-12-19 21:15:20 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42524 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698