Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 807173002: ES6 computed property names (Closed)

Created:
6 years ago by arv (Not doing code reviews)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ES6 computed property names This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. This is a revert of the revert, a76419f0f497db156eb1010e9b4be398951280cb with no changes. I cannot reproduce the issue on Win8.1 or WinXP. Letting the bots try again. BUG=v8:3754 LOG=Y TBR=dslomov@chromium.org Committed: https://crrev.com/a235b1076ae4b79baae1d17a5079cb6cfc462ba3 Cr-Commit-Position: refs/heads/master@{#25851}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1363 lines, -201 lines) Patch
M src/arm/full-codegen-arm.cc View 5 chunks +69 lines, -8 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 5 chunks +69 lines, -8 lines 0 comments Download
M src/ast.h View 3 chunks +21 lines, -17 lines 0 comments Download
M src/ast.cc View 6 chunks +33 lines, -17 lines 0 comments Download
M src/ast-numbering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +28 lines, -27 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +10 lines, -9 lines 0 comments Download
M src/full-codegen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +67 lines, -8 lines 2 comments Download
M src/parser.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/parser.cc View 5 chunks +12 lines, -7 lines 0 comments Download
M src/preparser.h View 18 chunks +98 lines, -33 lines 0 comments Download
M src/preparser.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/runtime.js View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-classes.cc View 2 chunks +1 line, -45 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M src/typing.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +67 lines, -8 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +62 lines, -1 line 0 comments Download
A test/mjsunit/harmony/computed-property-names.js View 1 chunk +270 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/computed-property-names-classes.js View 1 chunk +367 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/computed-property-names-object-literals-methods.js View 1 chunk +121 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807173002/1
6 years ago (2014-12-16 17:02:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 17:29:54 UTC) #3
arv (Not doing code reviews)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/807033003/ by arv@chromium.org. ...
6 years ago (2014-12-16 19:37:44 UTC) #4
adamk
Only thing wrong I see https://codereview.chromium.org/807173002/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://codereview.chromium.org/807173002/diff/1/src/ia32/full-codegen-ia32.cc#newcode1746 src/ia32/full-codegen-ia32.cc:1746: __ Drop(3); Should this ...
6 years ago (2014-12-16 19:57:49 UTC) #6
arv (Not doing code reviews)
https://codereview.chromium.org/807173002/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://codereview.chromium.org/807173002/diff/1/src/ia32/full-codegen-ia32.cc#newcode1746 src/ia32/full-codegen-ia32.cc:1746: __ Drop(3); On 2014/12/16 19:57:48, adamk wrote: > Should ...
6 years ago (2014-12-16 20:09:37 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-17 10:14:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a235b1076ae4b79baae1d17a5079cb6cfc462ba3
Cr-Commit-Position: refs/heads/master@{#25851}

Powered by Google App Engine
This is Rietveld 408576698