Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 807053005: Use BrowserCommandController's logic uniformly for bookmark command enable/disable (Closed)

Created:
6 years ago by Mike Wittman
Modified:
6 years ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use BrowserCommandController's logic uniformly for bookmark command enable/disable The logic for updating the bookmark command enable/disable state does not take the appropriate state into account on extension load/unload, resulting in e.g. bookmarking potentially not being disabled in popup windows. Just reuse the BrowserCommandController's logic instead. TEST=verified Ctrl-D in popup after extension enable has no effect BUG=442521 Committed: https://crrev.com/76df71db3b4dd707dbcf759beebf61dda6996d53 Cr-Commit-Position: refs/heads/master@{#309101}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -16 lines) Patch
M chrome/browser/ui/browser.cc View 1 chunk +2 lines, -16 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Mike Wittman
6 years ago (2014-12-17 23:32:30 UTC) #2
sky
LGTM
6 years ago (2014-12-18 20:08:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807053005/1
6 years ago (2014-12-18 21:05:58 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true in order for the CQ ...
6 years ago (2014-12-18 21:06:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807053005/20001
6 years ago (2014-12-18 21:21:17 UTC) #9
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true in order for the CQ ...
6 years ago (2014-12-18 21:21:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807053005/40001
6 years ago (2014-12-18 22:08:20 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-18 23:27:28 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-18 23:28:21 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/76df71db3b4dd707dbcf759beebf61dda6996d53
Cr-Commit-Position: refs/heads/master@{#309101}

Powered by Google App Engine
This is Rietveld 408576698