Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: chrome/browser/ui/browser_command_controller.h

Issue 807053005: Use BrowserCommandController's logic uniformly for bookmark command enable/disable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: . Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_command_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/prefs/pref_change_registrar.h" 10 #include "base/prefs/pref_change_registrar.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 int GetLastBlockedCommand(WindowOpenDisposition* disposition); 54 int GetLastBlockedCommand(WindowOpenDisposition* disposition);
55 55
56 // Notifies the controller that state has changed in one of the following 56 // Notifies the controller that state has changed in one of the following
57 // areas and it should update command states. 57 // areas and it should update command states.
58 void TabStateChanged(); 58 void TabStateChanged();
59 void ZoomStateChanged(); 59 void ZoomStateChanged();
60 void ContentRestrictionsChanged(); 60 void ContentRestrictionsChanged();
61 void FullscreenStateChanged(); 61 void FullscreenStateChanged();
62 void PrintingStateChanged(); 62 void PrintingStateChanged();
63 void LoadingStateChanged(bool is_loading, bool force); 63 void LoadingStateChanged(bool is_loading, bool force);
64 void ExtensionStateChanged();
64 65
65 // Shared state updating: these functions are static and public to share with 66 // Shared state updating: these functions are static and public to share with
66 // outside code. 67 // outside code.
67 68
68 // Updates the open-file state. 69 // Updates the open-file state.
69 static void UpdateOpenFileState(CommandUpdater* command_updater); 70 static void UpdateOpenFileState(CommandUpdater* command_updater);
70 71
71 // Update commands whose state depends on incognito mode availability and that 72 // Update commands whose state depends on incognito mode availability and that
72 // only depend on the profile. 73 // only depend on the profile.
73 static void UpdateSharedCommandsForIncognitoAvailability( 74 static void UpdateSharedCommandsForIncognitoAvailability(
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 PrefChangeRegistrar profile_pref_registrar_; 186 PrefChangeRegistrar profile_pref_registrar_;
186 PrefChangeRegistrar local_pref_registrar_; 187 PrefChangeRegistrar local_pref_registrar_;
187 BooleanPrefMember pref_signin_allowed_; 188 BooleanPrefMember pref_signin_allowed_;
188 189
189 DISALLOW_COPY_AND_ASSIGN(BrowserCommandController); 190 DISALLOW_COPY_AND_ASSIGN(BrowserCommandController);
190 }; 191 };
191 192
192 } // namespace chrome 193 } // namespace chrome
193 194
194 #endif // CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_H_ 195 #endif // CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_command_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698