Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 806943003: Use the unicode value for non ASCII characters (kanji) in calendarPicker.js (Closed)

Created:
5 years, 11 months ago by vivekg_samsung
Modified:
5 years, 11 months ago
Reviewers:
tkent, vivekg, haraken, keishi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use the unicode value for non ASCII characters (kanji) in calendarPicker.js While working on [1] and [2], we are trying to access the resources through the pak file generated using the grd file. In doing so for mojo, the pak file must be embedded in the generated binary. This has to be converted into the character array and then accessed from the mojo/services/html_viewer/blink_platform_impl. Here we use the ascii characters to validate the resource indeed is all in ascii. To fix this file, the special characters from kanji should be converted in their unicode equivalent. R=tkent@chromium.org [1] https://codereview.chromium.org/573553002 [2] https://codereview.chromium.org/827223002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/web/resources/calendarPicker.js View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
vivekg
PTAL, thanks.
5 years, 11 months ago (2015-01-08 15:37:45 UTC) #2
vivekg
On 2015/01/08 15:37:45, vivekg_ wrote: > PTAL, thanks. +haraken. Looks like tkent@ is away for ...
5 years, 11 months ago (2015-01-08 16:44:36 UTC) #4
haraken
+keishi: would you take a look at this?
5 years, 11 months ago (2015-01-08 23:40:52 UTC) #6
keishi
Unfortunate because it is harder to read but ok. LGTM.
5 years, 11 months ago (2015-01-09 02:19:08 UTC) #7
haraken
LGTM
5 years, 11 months ago (2015-01-09 02:20:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806943003/1
5 years, 11 months ago (2015-01-09 02:21:38 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 02:25:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188101

Powered by Google App Engine
This is Rietveld 408576698